From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 3E1C43858C54 for ; Sun, 6 Nov 2022 23:33:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E1C43858C54 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=google.com Received: by mail-pf1-x434.google.com with SMTP id b29so9088145pfp.13 for ; Sun, 06 Nov 2022 15:33:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B9WeW+tPtJw6LA8FkxrtEiAegxi8rfM1iYQcxFWSmFw=; b=SYTmiWN+vm7S5IJDvWWADsE8NQhnoZgQpNakC85VSQQ84KF+BZlnpNhAZi7oMPoNlN rHd3dEBOF8W+wzD0yV+f/I87Vnu1zOZtykk2WWrqaudUXS/2oRxC+ulYn44W3gm1ssVq TEdJ+0ZGNjgW2n34jvFG8c+Q4R7SrHUJ34dn22K5FinRbpT9BLLELbJz3cPcDPAwl8/0 nSpIKsMQr4bhtKWmSG+meAioHuwTUd4jua0DN3CanUlmYvJEkK1MtQcRjr9G3SQqWBhe qsBmE/zEt7znr1Dsn4rriGZZUTExnNNS7fYMhx0VYpYIntDdsCFkKg21LKy5NKNU9BTp LyfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B9WeW+tPtJw6LA8FkxrtEiAegxi8rfM1iYQcxFWSmFw=; b=ZsQlK0VFz66zavsbmXgNi7GmptfoEjJsMlNmVQgcj2uhK+L2vfeeP+9SKm9ZOQPHFI 45TNbtDRtrCQapM6E7Etp8H2VrDeMBK+f/YfEjZs0UZUxu5L9DHbhSMtEX4qYlR48+S3 0Yv1f46Krz14MHD4Etf4nI6ASBGvWysZdDMdIoTtwbigmQfB5WIA5ShekmZqh4xdyRYx MWx1jPT9mUNuBG0lq/R9N2Sl0Uwoy5FFMNJN9aYgOVH1nHfXGuaJFXYomiLXBLNLGvzg wtrlVfLX8Fq9RCzgcTFgUMq0CfDe531MMP49fEKt1kQ7HrZ12TYhrc1SlZZDkWZCwHeO kFUg== X-Gm-Message-State: ACrzQf0BbLrKw0XoOdwLgpMWKpC4oYL3ogObSYl5mE3sErwrlZdSCeJI 7wVRXTBc6JoiqTyoFv/GmftrUqx62vV6mA== X-Google-Smtp-Source: AMsMyM7ADR35Hj3Pq8leXZdQQfmp6vlWkZe8by13wDizu6EhkEWD6P81PfdJbpak7D4ozPwEwZdAJw== X-Received: by 2002:a63:571c:0:b0:452:e934:4058 with SMTP id l28-20020a63571c000000b00452e9344058mr39730250pgb.426.1667777614160; Sun, 06 Nov 2022 15:33:34 -0800 (PST) Received: from google.com ([2620:15c:2ce:200:8836:d128:f95d:95f3]) by smtp.gmail.com with ESMTPSA id i36-20020a635864000000b00464aa9ea6fasm2939216pgm.20.2022.11.06.15.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 15:33:33 -0800 (PST) Date: Sun, 6 Nov 2022 15:33:28 -0800 From: Fangrui Song To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 4/4] Apply asm redirection in gmp.h before first use Message-ID: <20221106233328.kf2uoibbe24omokm@google.com> References: <20221102145559.1962008-1-adhemerval.zanella@linaro.org> <20221102145559.1962008-5-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20221102145559.1962008-5-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-20.7 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-11-02, Adhemerval Zanella wrote: >For clang the redeclaration after the first use, the visibility attribute >is silently ignored (symbol is STV_DEFAULT) while the asm label attribute >causes an error. >--- > include/gmp.h | 12 --------- > stdlib/gmp.h | 72 ++++++++++++++++++++++++++++----------------------- > 2 files changed, 39 insertions(+), 45 deletions(-) > >[...] Looks good from v1. Reviewed-by: Fangrui Song