public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org, Fangrui Song <maskray@google.com>
Subject: [PATCH 7/7] Remove set-hooks.h from generic includes
Date: Tue, 15 Nov 2022 16:31:59 -0300	[thread overview]
Message-ID: <20221115193159.173838-8-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20221115193159.173838-1-adhemerval.zanella@linaro.org>

The hooks mechanism uses symbol sets for running lists of functions,
which requires either extra linker directives to provide any hardening
(such RELRO) or additional code (such as pointer obfuscation via
mangling with random value).

Currently only hurd uses it and there multiple examples where using
direct function call provides both hardening and good code generation
without the need to extra link or code handling (for instance
nptl/nptlfreeres.c).
---
 {include => hurd}/set-hooks.h  | 0
 nptl/nptlfreeres.c             | 1 -
 sysdeps/mach/hurd/bits/errno.h | 1 -
 3 files changed, 2 deletions(-)
 rename {include => hurd}/set-hooks.h (100%)

diff --git a/include/set-hooks.h b/hurd/set-hooks.h
similarity index 100%
rename from include/set-hooks.h
rename to hurd/set-hooks.h
diff --git a/nptl/nptlfreeres.c b/nptl/nptlfreeres.c
index c67456d9d3..90b7b13287 100644
--- a/nptl/nptlfreeres.c
+++ b/nptl/nptlfreeres.c
@@ -16,7 +16,6 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
-#include <set-hooks.h>
 #include <libc-symbols.h>
 #include <pthreadP.h>
 #include <nptl-stack.h>
-- 
2.34.1


      parent reply	other threads:[~2022-11-15 19:32 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-15 19:31 [PATCH 0/7] Fixing remaining lld issues Adhemerval Zanella
2022-11-15 19:31 ` [PATCH 1/7] configure: Move locale tools early Adhemerval Zanella
2022-11-15 19:31 ` [PATCH 2/7] elf: Do not assume symbol order on tst-audit25{a,b} Adhemerval Zanella
2022-12-12 12:36   ` Adhemerval Zanella Netto
2022-11-15 19:31 ` [PATCH 3/7] stdlib: Move _IO_cleanup to call_function_static_weak Adhemerval Zanella
2022-12-12 10:52   ` Florian Weimer
2022-12-13 16:52     ` Joseph Myers
2022-11-15 19:31 ` [PATCH 4/7] Move libc_freeres_ptrs and libc_subfreeres to weak functions Adhemerval Zanella
2022-12-12 10:55   ` Florian Weimer
2022-12-12 13:14     ` Adhemerval Zanella Netto
2022-12-12 10:58   ` Florian Weimer
2022-12-12 13:16     ` Adhemerval Zanella Netto
2022-12-12 11:00   ` Florian Weimer
2022-12-12 13:49     ` Adhemerval Zanella Netto
2022-12-12 14:05       ` Florian Weimer
2022-12-12 14:16         ` Adhemerval Zanella Netto
2022-12-12 15:39           ` Florian Weimer
2022-12-12 11:05   ` Andreas Schwab
2022-12-12 13:49     ` Adhemerval Zanella Netto
2022-12-12 11:08   ` Florian Weimer
2022-12-12 13:51     ` Adhemerval Zanella Netto
2022-11-15 19:31 ` [PATCH 5/7] libio: Remove the usage of __libc_IO_vtables Adhemerval Zanella
2022-12-12 11:40   ` Florian Weimer
2022-11-15 19:31 ` [PATCH 6/7] Remove --with-default-link configure option Adhemerval Zanella
2022-11-15 19:31 ` Adhemerval Zanella [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221115193159.173838-8-adhemerval.zanella@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=maskray@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).