From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: libc-alpha@sourceware.org
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>, commit-hurd@gnu.org
Subject: [hurd,commited 2/7] hurd _S_msg_add_auth: Initialize new arrays to 0
Date: Mon, 2 Jan 2023 11:09:33 +0100 [thread overview]
Message-ID: <20230102100938.2778311-3-samuel.thibault@ens-lyon.org> (raw)
In-Reply-To: <20230102100938.2778311-1-samuel.thibault@ens-lyon.org>
If make_list fails, they would be undefined, and freeup with free
uninitialized pointers.
---
hurd/hurdauth.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/hurd/hurdauth.c b/hurd/hurdauth.c
index 9086e9484c..25cc8ee88d 100644
--- a/hurd/hurdauth.c
+++ b/hurd/hurdauth.c
@@ -101,21 +101,24 @@ _S_msg_add_auth (mach_port_t me,
__mutex_lock (&_hurd_id.lock);
_hurd_check_ids ();
-#define MAKE(genaux,uidgid) \
- make_list (&new ## genaux ## uidgid ## s, \
+#define MAKE(genaux,uidgid) ({ \
+ new ## genaux ## uidgid ## s = 0; \
+ nnew ## genaux ## uidgid ## s = 0; \
+ make_list (&new ## genaux ## uidgid ## s, \
&nnew ## genaux ## uidgid ## s, \
_hurd_id.genaux.uidgid ## s, \
_hurd_id.genaux.n ## uidgid ## s, \
genaux ## uidgid ## s, \
- n ## genaux ## uidgid ## s)
+ n ## genaux ## uidgid ## s); \
+})
err = MAKE (gen, uid);
if (!err)
- MAKE (aux, uid);
+ err = MAKE (aux, uid);
if (!err)
- MAKE (gen, gid);
+ err = MAKE (gen, gid);
if (!err)
- MAKE (aux, gid);
+ err = MAKE (aux, gid);
#undef MAKE
__mutex_unlock (&_hurd_id.lock);
--
2.39.0
next prev parent reply other threads:[~2023-01-02 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 10:09 [hurd,commited 0/7] hurd: fixes Samuel Thibault
2023-01-02 10:09 ` [hurd,commited 1/7] htl: Check error returned by __getrlimit Samuel Thibault
2023-01-02 10:09 ` Samuel Thibault [this message]
2023-01-02 10:09 ` [hurd,commited 3/7] hurd hurdstartup: Initialize remaining fields of hurd_startup_data Samuel Thibault
2023-01-02 10:09 ` [hurd,commited 4/7] htl: Drop duplicate check in __pthread_stack_alloc Samuel Thibault
2023-01-02 10:09 ` [hurd,commited 5/7] hurd: Make dl-sysdep __sbrk check __vm_allocate call Samuel Thibault
2023-01-02 10:09 ` [hurd,commited 6/7] hurd fcntl: Make LOCKED macro more robust Samuel Thibault
2023-01-02 10:09 ` [hurd,commited 7/7] hurd getcwd: Fix memory leak on error Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230102100938.2778311-3-samuel.thibault@ens-lyon.org \
--to=samuel.thibault@ens-lyon.org \
--cc=commit-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).