From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id 87B3A38555B6 for ; Wed, 11 Jan 2023 20:46:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87B3A38555B6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-15eaa587226so2148441fac.8 for ; Wed, 11 Jan 2023 12:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=uR+tmviJAnIQt3Uy9C/8G52NzH6k6qWZDh0/RH+zyro=; b=gXB9lWEDuy7AOrzvp/apA3oFInRP+B38dAkTHASqApxtcYB8BPN/lEnFUXa98ODt2n 5APARiBYE3C4TGTdZbzDSUWkx8qOnAXX/qvYXt9dO3MSWObvPRG1PIFPA5yOfqzpq87q AAYnq/slDtp5qQ4r35wxPx2A/pcnUkbZMd0j6S5RIcG8OGJro2CVdc3f42hdZDpVg6MN j3lcoJEEXS7sCA7NK2dItPJcr/qEQBYw55D04TbBDJy3pPxaymZAAmgmlgk05dont5rq Q6d8NVZq4aicdK4YmmlMef2ztKIpQKkTM45xs4LLFpmRh7flAxaH4IzVrjSmGU8EfELQ 6fVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uR+tmviJAnIQt3Uy9C/8G52NzH6k6qWZDh0/RH+zyro=; b=FLx9aghkcNrCgtTJTl2Wnoa2BoD0Cl2U7dsUDy4suiXoo4BfELSpdUez2Y/Rj3sjVC uK2dY1sZWKEKTgzN4Mll856NYmFIisjtv00xv9UtzkAkm4/IHHOmZO31glyW/HtPs0qP jggluONKrQTFAZqE+JzZ1Gxly5yrW48jlfNcgGHqfT9lIdRZiRQDNr63aMZrlPdZNb5i Kv6WhRRzDd1pRJGpvh+BZq0L1Rde7Ll3RMwAvvHqiS9MghvzBcECTphERNOOzonEQaYp Lr5RVt4/+V/nnxbj977XAsnAexagC9aDI/elce7y2U23HXrF/uVcdKDVsJkihzj4xqKB fKig== X-Gm-Message-State: AFqh2kqHGc2vuoUA4M8Y/PMWo4YqzeAnpo4HtH0/NK8PfxGgBpYitk8O h3OTS97MHOyEOPQolD4b7JYuLqSkbqFdGYV0xJM= X-Google-Smtp-Source: AMrXdXscwVsQEXPLHY3QHk27Qwk6TjQe3hrLpE2ZIiVwLgLZ9FOdYNig1tNqoM9fxIZHIGX+zm1TDQ== X-Received: by 2002:a05:6871:b08:b0:15e:b2f4:adb7 with SMTP id fq8-20020a0568710b0800b0015eb2f4adb7mr729918oab.9.1673469989396; Wed, 11 Jan 2023 12:46:29 -0800 (PST) Received: from mandiga.. ([2804:1b3:a7c0:a93a:a504:f3f6:dd7b:801]) by smtp.gmail.com with ESMTPSA id kw18-20020a056870ac1200b0014c8b5d54b2sm7990274oab.20.2023.01.11.12.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 12:46:28 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Noah Goldstein , Richard Henderson Subject: [PATCH v7 12/17] hppa: Add memcopy.h Date: Wed, 11 Jan 2023 17:45:53 -0300 Message-Id: <20230111204558.2402155-13-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230111204558.2402155-1-adhemerval.zanella@linaro.org> References: <20230111204558.2402155-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Richard Henderson GCC's combine pass cannot merge (x >> c | y << (32 - c)) into a double-word shift unless (1) the subtract is in the same basic block and (2) the result of the subtract is used exactly once. Neither condition is true for any use of MERGE. By forcing the use of a double-word shift, we not only reduce contention on SAR, but also allow the setting of SAR to be hoisted outside of a loop. Checked on hppa-linux-gnu. --- sysdeps/hppa/memcopy.h | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 sysdeps/hppa/memcopy.h diff --git a/sysdeps/hppa/memcopy.h b/sysdeps/hppa/memcopy.h new file mode 100644 index 0000000000..0d4b4ac435 --- /dev/null +++ b/sysdeps/hppa/memcopy.h @@ -0,0 +1,42 @@ +/* Definitions for memory copy functions, PA-RISC version. + Copyright (C) 2023 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#include + +/* Use a single double-word shift instead of two shifts and an ior. + If the uses of MERGE were close to the computation of shl/shr, + the compiler might have been able to create this itself. + But instead that computation is well separated. + + Using an inline function instead of a macro is the easiest way + to ensure that the types are correct. */ + +#undef MERGE + +static __always_inline op_t +MERGE (op_t w0, int shl, op_t w1, int shr) +{ + _Static_assert (OPSIZ == 4 || OPSIZ == 8, "Invalid OPSIZE"); + + op_t res; + if (OPSIZ == 4) + asm ("shrpw %1,%2,%%sar,%0" : "=r"(res) : "r"(w0), "r"(w1), "q"(shr)); + else if (OPSIZ == 8) + asm ("shrpd %1,%2,%%sar,%0" : "=r"(res) : "r"(w0), "r"(w1), "q"(shr)); + return res; +} -- 2.34.1