From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org,
Noah Goldstein <goldstein.w.n@gmail.com>,
Richard Henderson <richard.henderson@linaro.org>
Cc: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Subject: [PATCH v7 01/17] Parameterize op_t from memcopy.h
Date: Wed, 11 Jan 2023 17:45:42 -0300 [thread overview]
Message-ID: <20230111204558.2402155-2-adhemerval.zanella@linaro.org> (raw)
In-Reply-To: <20230111204558.2402155-1-adhemerval.zanella@linaro.org>
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
It moves the op_t definition out to an specific header, adds
the attribute 'may-alias', and cleanup its duplicated definitions.
Checked with a build and check with run-built-tests=no for all major
Linux ABIs.
---
string/memcmp.c | 1 -
sysdeps/generic/memcopy.h | 6 ++----
sysdeps/generic/string-optype.h | 24 ++++++++++++++++++++++++
sysdeps/x86_64/x32/string-optype.h | 24 ++++++++++++++++++++++++
4 files changed, 50 insertions(+), 5 deletions(-)
create mode 100644 sysdeps/generic/string-optype.h
create mode 100644 sysdeps/x86_64/x32/string-optype.h
diff --git a/string/memcmp.c b/string/memcmp.c
index 067b2e6a42..ea0fa03e1c 100644
--- a/string/memcmp.c
+++ b/string/memcmp.c
@@ -46,7 +46,6 @@
/* Type to use for aligned memory operations.
This should normally be the biggest type supported by a single load
and store. Must be an unsigned type. */
-# define op_t unsigned long int
# define OPSIZ (sizeof (op_t))
/* Threshold value for when to enter the unrolled loops. */
diff --git a/sysdeps/generic/memcopy.h b/sysdeps/generic/memcopy.h
index 9f3ffb5d30..b5ffa4d114 100644
--- a/sysdeps/generic/memcopy.h
+++ b/sysdeps/generic/memcopy.h
@@ -55,10 +55,8 @@
[I fail to understand. I feel stupid. --roland]
*/
-/* Type to use for aligned memory operations.
- This should normally be the biggest type supported by a single load
- and store. */
-#define op_t unsigned long int
+/* Type to use for aligned memory operations. */
+#include <string-optype.h>
#define OPSIZ (sizeof (op_t))
/* Type to use for unaligned operations. */
diff --git a/sysdeps/generic/string-optype.h b/sysdeps/generic/string-optype.h
new file mode 100644
index 0000000000..42bdd2a145
--- /dev/null
+++ b/sysdeps/generic/string-optype.h
@@ -0,0 +1,24 @@
+/* Define a type to use for word access. Generic version.
+ Copyright (C) 2023 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifndef _STRING_OPTYPE_H
+#define _STRING_OPTYPE_H 1
+
+typedef unsigned long int __attribute__ ((__may_alias__)) op_t;
+
+#endif /* string-optype.h */
diff --git a/sysdeps/x86_64/x32/string-optype.h b/sysdeps/x86_64/x32/string-optype.h
new file mode 100644
index 0000000000..e7679f934f
--- /dev/null
+++ b/sysdeps/x86_64/x32/string-optype.h
@@ -0,0 +1,24 @@
+/* Define a type to use for word access. Generic version.
+ Copyright (C) 2023 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifndef _STRING_OPTYPE_H
+#define _STRING_OPTYPE_H 1
+
+typedef unsigned long long int __attribute__ ((__may_alias__)) op_t;
+
+#endif /* string-optype.h */
--
2.34.1
next prev parent reply other threads:[~2023-01-11 20:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 20:45 [PATCH v7 00/17] Improve generic string routines Adhemerval Zanella
2023-01-11 20:45 ` Adhemerval Zanella [this message]
2023-01-11 20:45 ` [PATCH v7 02/17] Parameterize OP_T_THRES from memcopy.h Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 03/17] Add string-maskoff.h generic header Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 04/17] Add string vectorized find and detection functions Adhemerval Zanella
2023-01-12 16:29 ` Richard Henderson
2023-01-13 17:24 ` Adhemerval Zanella Netto
2023-01-13 17:50 ` Richard Henderson
2023-01-13 18:03 ` Adhemerval Zanella Netto
2023-01-11 20:45 ` [PATCH v7 05/17] string: Improve generic strlen Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 06/17] string: Improve generic strnlen Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 07/17] string: Improve generic strchr Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 08/17] string: Improve generic strchrnul Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 09/17] string: Improve generic strcmp Adhemerval Zanella
2023-01-12 17:20 ` Noah Goldstein
2023-01-12 17:26 ` Carlos Seo
2023-01-13 18:25 ` Adhemerval Zanella Netto
2023-01-11 20:45 ` [PATCH v7 10/17] string: Improve generic memchr Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 11/17] string: Improve generic memrchr Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 12/17] hppa: Add memcopy.h Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 13/17] hppa: Add string-fzb.h and string-fzi.h Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 14/17] alpha: " Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 15/17] arm: Add string-fza.h Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 16/17] powerpc: " Adhemerval Zanella
2023-01-11 20:45 ` [PATCH v7 17/17] sh: Add string-fzb.h Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230111204558.2402155-2-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).