public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: libc-alpha@sourceware.org
Cc: adhemerval.zanella@linaro.org, goldstein.w.n@gmail.com
Subject: [PATCH v8 12/17] hppa: Add memcopy.h
Date: Fri, 13 Jan 2023 08:27:28 -1000	[thread overview]
Message-ID: <20230113182733.1268668-13-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230113182733.1268668-1-richard.henderson@linaro.org>

GCC's combine pass cannot merge (x >> c | y << (32 - c)) into a
double-word shift unless (1) the subtract is in the same basic block
and (2) the result of the subtract is used exactly once.  Neither
condition is true for any use of MERGE.

By forcing the use of a double-word shift, we not only reduce
contention on SAR, but also allow the setting of SAR to be hoisted
outside of a loop.

Checked on hppa-linux-gnu.
Message-Id: <20230111204558.2402155-13-adhemerval.zanella@linaro.org>
---
 sysdeps/hppa/memcopy.h | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 sysdeps/hppa/memcopy.h

diff --git a/sysdeps/hppa/memcopy.h b/sysdeps/hppa/memcopy.h
new file mode 100644
index 0000000000..0d4b4ac435
--- /dev/null
+++ b/sysdeps/hppa/memcopy.h
@@ -0,0 +1,42 @@
+/* Definitions for memory copy functions, PA-RISC version.
+   Copyright (C) 2023 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library.  If not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include <sysdeps/generic/memcopy.h>
+
+/* Use a single double-word shift instead of two shifts and an ior.
+   If the uses of MERGE were close to the computation of shl/shr,
+   the compiler might have been able to create this itself.
+   But instead that computation is well separated.
+
+   Using an inline function instead of a macro is the easiest way
+   to ensure that the types are correct.  */
+
+#undef MERGE
+
+static __always_inline op_t
+MERGE (op_t w0, int shl, op_t w1, int shr)
+{
+  _Static_assert (OPSIZ == 4 || OPSIZ == 8, "Invalid OPSIZE");
+
+  op_t res;
+  if (OPSIZ == 4)
+    asm ("shrpw %1,%2,%%sar,%0" : "=r"(res) : "r"(w0), "r"(w1), "q"(shr));
+  else if (OPSIZ == 8)
+    asm ("shrpd %1,%2,%%sar,%0" : "=r"(res) : "r"(w0), "r"(w1), "q"(shr));
+  return res;
+}
-- 
2.34.1


  parent reply	other threads:[~2023-01-13 18:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 18:27 [PATCH v8 00/17] Improve generic string routines Richard Henderson
2023-01-13 18:27 ` [PATCH v8 01/17] Parameterize op_t from memcopy.h Richard Henderson
2023-01-16 20:52   ` Richard Henderson
2023-01-13 18:27 ` [PATCH v8 02/17] Parameterize OP_T_THRES " Richard Henderson
2023-01-16 20:52   ` Richard Henderson
2023-01-13 18:27 ` [PATCH v8 03/17] Add string-maskoff.h generic header Richard Henderson
2023-01-16 20:58   ` Richard Henderson
2023-01-17 18:49     ` Adhemerval Zanella Netto
2023-01-18  1:33       ` Richard Henderson
2023-01-18 12:45         ` Adhemerval Zanella Netto
2023-01-13 18:27 ` [PATCH v8 04/17] Add string vectorized find and detection functions Richard Henderson
2023-01-16 21:04   ` Richard Henderson
2023-01-13 18:27 ` [PATCH v8 05/17] string: Improve generic strlen Richard Henderson
2023-01-13 18:27 ` [PATCH v8 06/17] string: Improve generic strnlen Richard Henderson
2023-01-13 18:27 ` [PATCH v8 07/17] string: Improve generic strchr Richard Henderson
2023-01-13 18:27 ` [PATCH v8 08/17] string: Improve generic strchrnul Richard Henderson
2023-01-13 18:27 ` [PATCH v8 09/17] string: Improve generic strcmp Richard Henderson
2023-01-13 18:27 ` [PATCH v8 10/17] string: Improve generic memchr Richard Henderson
2023-01-13 18:27 ` [PATCH v8 11/17] string: Improve generic memrchr Richard Henderson
2023-01-13 18:27 ` Richard Henderson [this message]
2023-01-13 18:27 ` [PATCH v8 13/17] hppa: Add string-fzb.h and string-fzi.h Richard Henderson
2023-01-13 18:27 ` [PATCH v8 14/17] alpha: " Richard Henderson
2023-01-13 18:27 ` [PATCH v8 15/17] arm: Add string-fza.h Richard Henderson
2023-01-13 18:27 ` [PATCH v8 16/17] powerpc: " Richard Henderson
2023-01-17 14:35   ` Adhemerval Zanella Netto
2023-01-13 18:27 ` [PATCH v8 17/17] sh: Add string-fzb.h Richard Henderson
2023-01-17 14:35   ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113182733.1268668-13-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=goldstein.w.n@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).