public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: libc-alpha@sourceware.org
Cc: adhemerval.zanella@linaro.org, goldstein.w.n@gmail.com
Subject: [PATCH v8 14/17] alpha: Add string-fzb.h and string-fzi.h
Date: Fri, 13 Jan 2023 08:27:30 -1000	[thread overview]
Message-ID: <20230113182733.1268668-15-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230113182733.1268668-1-richard.henderson@linaro.org>

While alpha has the more important string functions in assembly,
there are still a few for find the generic routines are used.

Use the CMPBGE insn, via the builtin, for testing of zeros.  Use a
simplified expansion of __builtin_ctz when the insn isn't available.

Checked on alpha-linux-gnu.

Co-authored-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
Message-Id: <20230111204558.2402155-15-adhemerval.zanella@linaro.org>
---
 sysdeps/alpha/string-fza.h | 72 ++++++++++++++++++++++++++++++++++++++
 sysdeps/alpha/string-fzb.h | 52 +++++++++++++++++++++++++++
 sysdeps/alpha/string-fzi.h | 62 ++++++++++++++++++++++++++++++++
 3 files changed, 186 insertions(+)
 create mode 100644 sysdeps/alpha/string-fza.h
 create mode 100644 sysdeps/alpha/string-fzb.h
 create mode 100644 sysdeps/alpha/string-fzi.h

diff --git a/sysdeps/alpha/string-fza.h b/sysdeps/alpha/string-fza.h
new file mode 100644
index 0000000000..4ada6c385c
--- /dev/null
+++ b/sysdeps/alpha/string-fza.h
@@ -0,0 +1,72 @@
+/* Basic zero byte detection.  Generic C version.
+   Copyright (C) 2023 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#ifndef _STRING_FZA_H
+#define _STRING_FZA_H 1
+
+#include <limits.h>
+#include <string-optype.h>
+#include <string-maskoff.h>
+
+/*
+ * The CMPBGE instruction creates a bit mask rather than a byte mask.
+ * However, if we narrow find_t to either 'int' or 'uint8_t', we get
+ * unnecessary truncation instructions from the 'unsigned long' type
+ * returned by __builtin_alpha_cmpbge.
+ */
+typedef op_t find_t;
+
+static __always_inline find_t
+find_zero_all (op_t x)
+{
+  return __builtin_alpha_cmpbge (0, x);
+}
+
+static __always_inline find_t
+find_eq_all (op_t x1, op_t x2)
+{
+  return find_zero_all (x1 ^ x2);
+}
+
+static __always_inline find_t
+find_zero_eq_all (op_t x1, op_t x2)
+{
+  return find_zero_all (x1) | find_zero_all (x1 ^ x2);
+}
+
+static __always_inline find_t
+find_zero_ne_all (op_t x1, op_t x2)
+{
+  return find_zero_all (x1) | (find_zero_all (x1 ^ x2) ^ 0xff);
+}
+
+/* Return the mask WORD shifted based on S_INT address value, to ignore
+   values not presented in the aligned word read.  */
+static __always_inline find_t
+shift_find (find_t word, uintptr_t s)
+{
+  return word >> (s % sizeof (op_t));
+}
+
+/* Define the "inexact" versions in terms of the exact versions.  */
+#define find_zero_low		find_zero_all
+#define find_eq_low		find_eq_all
+#define find_zero_eq_low	find_zero_eq_all
+#define find_zero_ne_low	find_zero_ne_all
+
+#endif /* _STRING_FZA_H */
diff --git a/sysdeps/alpha/string-fzb.h b/sysdeps/alpha/string-fzb.h
new file mode 100644
index 0000000000..e3934ba413
--- /dev/null
+++ b/sysdeps/alpha/string-fzb.h
@@ -0,0 +1,52 @@
+/* Zero byte detection; boolean.  Alpha version.
+   Copyright (C) 2023 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#ifndef _STRING_FZB_H
+#define _STRING_FZB_H 1
+
+#include <sys/cdefs.h>
+#include <string-optype.h>
+
+/* Note that since CMPBGE creates a bit mask rather than a byte mask,
+   we cannot simply provide a target-specific string-fza.h.  */
+
+/* Determine if any byte within X is zero.  This is a pure boolean test.  */
+
+static __always_inline _Bool
+has_zero (op_t x)
+{
+  return __builtin_alpha_cmpbge (0, x) != 0;
+}
+
+/* Likewise, but for byte equality between X1 and X2.  */
+
+static __always_inline _Bool
+has_eq (op_t x1, op_t x2)
+{
+  return has_zero (x1 ^ x2);
+}
+
+/* Likewise, but for zeros in X1 and equal bytes between X1 and X2.  */
+
+static __always_inline _Bool
+has_zero_eq (op_t x1, op_t x2)
+{
+  return has_zero (x1) | has_eq (x1, x2);
+}
+
+#endif /* _STRING_FZB_H */
diff --git a/sysdeps/alpha/string-fzi.h b/sysdeps/alpha/string-fzi.h
new file mode 100644
index 0000000000..5129b892e7
--- /dev/null
+++ b/sysdeps/alpha/string-fzi.h
@@ -0,0 +1,62 @@
+/* string-fzi.h -- zero byte detection; indices.  Alpha version.
+   Copyright (C) 2022 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#ifndef _STRING_FZI_H
+#define _STRING_FZI_H
+
+#include <stdint.h>
+#include <string-optype.h>
+#include <string-fza.h>
+
+/* Note that since CMPBGE creates a bit mask rather than a byte mask,
+   we cannot simply provide a target-specific string-fza.h.  */
+
+/* A subroutine for the index_zero functions.  Given a bitmask C,
+   return the index of the first bit set in memory order.  */
+static __always_inline unsigned int
+index_first (find_t c)
+{
+#ifdef __alpha_cix__
+  return __builtin_ctzl (c);
+#else
+  c = c & -c;
+  return (c & 0xf0 ? 4 : 0) + (c & 0xcc ? 2 : 0) + (c & 0xaa ? 1 : 0);
+#endif
+}
+
+/* Similarly, but return the (memory order) index of the last bit
+   that is non-zero.  Note that only the least 8 bits may be nonzero.  */
+
+static __always_inline unsigned int
+index_last (find_t x)
+{
+#ifdef __alpha_cix__
+  return __builtin_clzl (x) ^ 63;
+#else
+  unsigned r = 0;
+  if (x & 0xf0)
+    r += 4;
+  if (x & (0xc << r))
+    r += 2;
+  if (x & (0x2 << r))
+    r += 1;
+  return r;
+#endif
+}
+
+#endif /* _STRING_FZI_H */
-- 
2.34.1


  parent reply	other threads:[~2023-01-13 18:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 18:27 [PATCH v8 00/17] Improve generic string routines Richard Henderson
2023-01-13 18:27 ` [PATCH v8 01/17] Parameterize op_t from memcopy.h Richard Henderson
2023-01-16 20:52   ` Richard Henderson
2023-01-13 18:27 ` [PATCH v8 02/17] Parameterize OP_T_THRES " Richard Henderson
2023-01-16 20:52   ` Richard Henderson
2023-01-13 18:27 ` [PATCH v8 03/17] Add string-maskoff.h generic header Richard Henderson
2023-01-16 20:58   ` Richard Henderson
2023-01-17 18:49     ` Adhemerval Zanella Netto
2023-01-18  1:33       ` Richard Henderson
2023-01-18 12:45         ` Adhemerval Zanella Netto
2023-01-13 18:27 ` [PATCH v8 04/17] Add string vectorized find and detection functions Richard Henderson
2023-01-16 21:04   ` Richard Henderson
2023-01-13 18:27 ` [PATCH v8 05/17] string: Improve generic strlen Richard Henderson
2023-01-13 18:27 ` [PATCH v8 06/17] string: Improve generic strnlen Richard Henderson
2023-01-13 18:27 ` [PATCH v8 07/17] string: Improve generic strchr Richard Henderson
2023-01-13 18:27 ` [PATCH v8 08/17] string: Improve generic strchrnul Richard Henderson
2023-01-13 18:27 ` [PATCH v8 09/17] string: Improve generic strcmp Richard Henderson
2023-01-13 18:27 ` [PATCH v8 10/17] string: Improve generic memchr Richard Henderson
2023-01-13 18:27 ` [PATCH v8 11/17] string: Improve generic memrchr Richard Henderson
2023-01-13 18:27 ` [PATCH v8 12/17] hppa: Add memcopy.h Richard Henderson
2023-01-13 18:27 ` [PATCH v8 13/17] hppa: Add string-fzb.h and string-fzi.h Richard Henderson
2023-01-13 18:27 ` Richard Henderson [this message]
2023-01-13 18:27 ` [PATCH v8 15/17] arm: Add string-fza.h Richard Henderson
2023-01-13 18:27 ` [PATCH v8 16/17] powerpc: " Richard Henderson
2023-01-17 14:35   ` Adhemerval Zanella Netto
2023-01-13 18:27 ` [PATCH v8 17/17] sh: Add string-fzb.h Richard Henderson
2023-01-17 14:35   ` Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230113182733.1268668-15-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=adhemerval.zanella@linaro.org \
    --cc=goldstein.w.n@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).