From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id D5CC73858D32 for ; Sun, 29 Jan 2023 23:25:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D5CC73858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMH3S-0007Is-EW; Sun, 29 Jan 2023 18:25:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=bnHAKPZv2vqcfaf0/PI3OxY2WGoVHiVuDOyvxWfIxIk=; b=SSzMfQf5zhPSXHFWFOfi MJxvxUqlY0/S/EHk8IgikITU4oFfzl4FwXXr9cYHBI/iFaEFLqc3T8VA0eVQNLXXu+1ifm6ESxJcI tqmfPNfUTSGg/0ijuTv7gRA3hwaNwVKcR6RKFsrEeudbs4RKlCmzmZ1M+u+523OpgcZ4iAlT8D91s oXO5XNkBF36LnZdCBVyCktQW+V1TRFJEQXv3UZB5r+3OpAkyTdXFmxRS5Ckbg6f/T7Ow/1iAHlLkN /JzVyHxC7Uk7I1b259A0ZMyFb2/s5F7pG/9dLh0AukkeY+CErHXvd/e+3jXE9yhxBFtrVqzF7N+uy Q6n7CdJgxzJJtA==; Received: from lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr ([92.158.138.184] helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMH3S-0004oj-7k; Sun, 29 Jan 2023 18:25:46 -0500 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pMH3O-0012gL-2c; Mon, 30 Jan 2023 00:25:42 +0100 Date: Mon, 30 Jan 2023 00:25:42 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org Subject: Re: [RFC PATCH 2/3] hurd: Implement O_TMPFILE Message-ID: <20230129232542.ns72yrj7vg2djpon@begin> Mail-Followup-To: Sergey Bugaev , bug-hurd@gnu.org, libc-alpha@sourceware.org References: <20221212114636.74222-1-bugaevc@gmail.com> <20221212114636.74222-3-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221212114636.74222-3-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Sergey Bugaev, le lun. 12 déc. 2022 14:46:35 +0300, a ecrit: > diff --git a/sysdeps/mach/hurd/bits/fcntl.h b/sysdeps/mach/hurd/bits/fcntl.h > index 17dcb384..b898a0c5 100644 > --- a/sysdeps/mach/hurd/bits/fcntl.h > +++ b/sysdeps/mach/hurd/bits/fcntl.h > @@ -123,6 +123,11 @@ > # define O_CLOEXEC 0x00400000 /* Set FD_CLOEXEC. */ > #endif > > +#ifdef __USE_GNU > +# define __O_TMPFILE 0x00800000 /* Make a new unnamed file. */ > +# define O_TMPFILE (__O_TMPFILE | O_DIRECTORY) > +#endif I don't think we need the __O_TMPFILE variant, only the O_TMPFILE one? Linux uses __ variants just because it has per-arch definitions. Samuel