From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id 166403858D1E for ; Mon, 30 Jan 2023 11:06:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 166403858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=strace.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 9674372C8D0; Mon, 30 Jan 2023 14:06:52 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 871147CE111; Mon, 30 Jan 2023 14:06:52 +0300 (MSK) Date: Mon, 30 Jan 2023 14:06:52 +0300 From: "Dmitry V. Levin" To: Florian Weimer Cc: strace development discussions , libc-alpha@sourceware.org Subject: Re: [PATCH v6 04/11] stdio-common: Add __translated_number_width Message-ID: <20230130110652.GA13823@altlinux.org> References: <20230130094055.GA12568@altlinux.org> <87k014z4ky.fsf@oldenburg.str.redhat.com> <20230130105143.GA13333@altlinux.org> <87bkmgz3lv.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bkmgz3lv.fsf@oldenburg.str.redhat.com> X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 30, 2023 at 12:03:24PM +0100, Florian Weimer wrote: > * Dmitry V. Levin: > > > On Mon, Jan 30, 2023 at 11:42:21AM +0100, Florian Weimer via Libc-alpha wrote: > >> * Dmitry V. Levin: > >> > >> > Hi, > >> > > >> > On Fri, Dec 16, 2022 at 09:15:22PM +0100, Florian Weimer via Libc-alpha wrote: > >> >> This function will be used to compute the width of a number > >> >> after i18n digit translation. > >> > > >> > I haven't bisected, but I suppose it was this changeset that introduced > >> > a regression reported by the strace test suite. > >> > > >> > glibc-2.36$ cat <<'EOF' |gcc -xc - && ./a.out > >> > #include > >> > int main() { printf("%03d\n", 1); return 0; } > >> > EOF > >> > 001 > >> > > >> > The same test on master prints 0001 instead of 001. > >> > >> Sorry, I can't reproduce it. Did you build glibc yourself from upstream > >> sources, or did you get the build from somewhere else? > > > > This was initially reported by the strace test suite running on > > rawhide-test.fedorainfracloud.org, and I suppose the patch submitted > > by Andreas today fixes it. > > Andreas' fix is for %#03o, though. Perhaps the reduction above is > incorrect? Oops, I posted the wrong reduction, it was originally %#03o indeed. -- ldv