From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cventin.lip.ens-lyon.fr (cventin.lip.ens-lyon.fr [140.77.13.17]) by sourceware.org (Postfix) with ESMTPS id C40763858C60 for ; Thu, 2 Feb 2023 13:10:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C40763858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vinc17.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=vinc17.net Received: from vlefevre by cventin.lip.ens-lyon.fr with local (Exim 4.96) (envelope-from ) id 1pNZM6-00Deoh-01; Thu, 02 Feb 2023 14:10:22 +0100 Date: Thu, 2 Feb 2023 14:10:21 +0100 From: Vincent Lefevre To: libc-alpha@sourceware.org Subject: Re: [PATCH] Account for grouping in printf width (bug 23432) Message-ID: <20230202131021.GA3235488@cventin.lip.ens-lyon.fr> References: <87pmb8ktdo.fsf@mid.deneb.enyo.de> <9531aa0c-bb05-ab2f-fd48-0751fb6f4393@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9531aa0c-bb05-ab2f-fd48-0751fb6f4393@redhat.com> X-Mailer-Info: https://www.vinc17.net/mutt/ User-Agent: Mutt/2.2.9+60 (9917c0ea) vl-149028 (2022-12-12) X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-22 18:20:52 -0500, Carlos O'Donell wrote: > On 1/21/23 06:40, Florian Weimer wrote: > > * Andreas Schwab via Libc-alpha: > > > >> diff --git a/stdio-common/Makefile b/stdio-common/Makefile > >> index 6e9d104524..b46d932a20 100644 > >> --- a/stdio-common/Makefile > >> +++ b/stdio-common/Makefile > >> @@ -195,6 +195,7 @@ tests := \ > >> tst-gets \ > >> tst-grouping \ > >> tst-grouping2 \ > >> + tst-grouping3 \ > >> tst-long-dbl-fphex \ > >> tst-memstream-string \ > >> tst-obprintf \ > > > > Missing $(gen-locales) dependency. The change itself seems okay, it > > seems to align with POSIX. Not sure if this is still possibly to > > apply during the freeze. > > I'd like to avoid a partial fix like this just before we release 2.27. 2.37 > My preference would be to review this more thoroughly, apply it when > 2.28 opens, and then backport when we have confidence the issue is ^^^^ 2.38 > resolved. There's actually another bug, which is a regression in glibc 2.37 and a security issue (possible buffer overflow resulting from this new bug, as additional characters are output): https://sourceware.org/bugzilla/show_bug.cgi?id=30068 and according to https://sourceware.org/bugzilla/show_bug.cgi?id=30068#c5 this patch fixes this new bug. (In bug 23432, I was considering only the precision field, while in bug 30068, this is the width field, though these issues may be related in the implementation.) -- Vincent Lefèvre - Web: 100% accessible validated (X)HTML - Blog: Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)