From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from forward105o.mail.yandex.net (forward105o.mail.yandex.net [37.140.190.183]) by sourceware.org (Postfix) with ESMTPS id 5FB063858D28 for ; Fri, 10 Feb 2023 14:07:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5FB063858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=yandex.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yandex.ru Received: from forward100q.mail.yandex.net (forward100q.mail.yandex.net [IPv6:2a02:6b8:c0e:4b:0:640:4012:bb97]) by forward105o.mail.yandex.net (Yandex) with ESMTP id 8381F4C3E8C for ; Fri, 10 Feb 2023 17:07:50 +0300 (MSK) Received: from vla3-aeadfdeff55e.qloud-c.yandex.net (vla3-aeadfdeff55e.qloud-c.yandex.net [IPv6:2a02:6b8:c15:341d:0:640:aead:fdef]) by forward100q.mail.yandex.net (Yandex) with ESMTP id 7F50E6F40007 for ; Fri, 10 Feb 2023 17:07:50 +0300 (MSK) Received: by vla3-aeadfdeff55e.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id l7gEnKCZhiE1-koQgyCyR; Fri, 10 Feb 2023 17:07:49 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1676038070; bh=C+nDotYE4WpQ7hGhms4TfaPahaQgwggizU7CU46d9s8=; h=Message-Id:Date:Cc:Subject:To:From; b=Xqt/e7w+ku2V2vTDwCbGGT2BIKm2KWIOxdPnsOLM6fwDMDkjqy0Apy98DUxVQwv4b rk2+3xgkWJEgw2l4sdbTPgFj1IqrLkMeHvRcUYfR5pFR792vNl3c6gNLAhFjc+MLLR ksZF86yQptn/R3DPPEFf2RI4Xsp4hvYfituA9nIE= Authentication-Results: vla3-aeadfdeff55e.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru From: Stas Sergeev To: libc-alpha@sourceware.org Cc: Stas Sergeev Subject: [PATCH 1/2] elf: strdup() l_name if no realname [BZ #30100] Date: Fri, 10 Feb 2023 19:07:43 +0500 Message-Id: <20230210140744.2828787-1-stsp2@yandex.ru> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: _dl_close_worker() has this code: /* This name always is allocated. */ free (imap->l_name); But in that particular case, while indeed being allocated, l_name doesn't point to the start of an allocation: new = (struct link_map *) calloc (sizeof (*new) + audit_space + sizeof (struct link_map *) + sizeof (*newname) + libname_len, 1); ... new->l_symbolic_searchlist.r_list = (struct link_map **) ((char *) (new + 1) + audit_space); new->l_libname = newname = (struct libname_list *) (new->l_symbolic_searchlist.r_list + 1); newname->name = (char *) memcpy (newname + 1, libname, libname_len); ... new->l_name = (char *) newname->name + libname_len - 1; It therefore cannot be freed separately. Use strdup() as a simple fix. Signed-off-by: Stas Sergeev --- elf/dl-object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elf/dl-object.c b/elf/dl-object.c index f1f2ec956c..c92daf37d1 100644 --- a/elf/dl-object.c +++ b/elf/dl-object.c @@ -122,7 +122,7 @@ _dl_new_object (char *realname, const char *libname, int type, #endif new->l_name = realname; else - new->l_name = (char *) newname->name + libname_len - 1; + new->l_name = __strdup ((char *) newname->name + libname_len - 1); new->l_type = type; /* If we set the bit now since we know it is never used we avoid -- 2.37.2