From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id F41FE3858C52 for ; Sun, 12 Feb 2023 14:52:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F41FE3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRDiH-0002dH-JY; Sun, 12 Feb 2023 09:52:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=owYJEGi4OM6YqytSaU2OcRVUpfRWLCW+etRIaRr0rt4=; b=CqvpdstaSAoTe7eEicFA PRRHq+4tSA/4xIP6dk1/npd92vZPMkoisBOy+VBSwiXastS6EssyV6rTh6yyQN5MZDEq0ZDP63az8 Y2xbaweU03sTDx9HtU0zsWCBsX02QDEnUrEbPiCA5do+E3sf5ism4aMHPP2F1/EXbkWj5vKyhKn4w Q4c+gyKFon8W+2ydAHCTEWcVoujVARlPB7IQXl+7zBMU7BJBHpl//gapwcyrbZy+h6uT8TgaPxw00 pWVNSdzqQf0r5Stn3pX+S2TZoYu52fJT4+7iZHd95MWqvxw27uHofEHrcX0QtBw9RoSyUZuMnA8HJ lP0VdxBiIcshWA==; Received: from lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr ([92.158.138.184] helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRDiH-0000tI-9G; Sun, 12 Feb 2023 09:52:21 -0500 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRDiF-004nKR-02; Sun, 12 Feb 2023 15:52:19 +0100 Date: Sun, 12 Feb 2023 15:52:18 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz Subject: Re: [RFC PATCH glibc 2/12] hurd: Use mach_msg_type_number_t where appropriate Message-ID: <20230212145218.njxsnq7jwivs6vtj@begin> Mail-Followup-To: Sergey Bugaev , bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz References: <20230212111044.610942-1-bugaevc@gmail.com> <20230212111044.610942-3-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230212111044.610942-3-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied, thanks! Sergey Bugaev via Libc-alpha, le dim. 12 févr. 2023 14:10:33 +0300, a ecrit: > It has been decided that on x86_64, mach_msg_type_number_t stays 32-bit. > Therefore, it's not possible to use mach_msg_type_number_t > interchangeably with size_t, in particular this breaks when a pointer to > a variable is passed to a MIG routine. > > Signed-off-by: Sergey Bugaev > --- > hurd/hurdioctl.c | 2 +- > hurd/hurdprio.c | 2 +- > hurd/lookup-retry.c | 2 +- > hurd/xattr.c | 4 ++-- > sysdeps/mach/hurd/getcwd.c | 2 +- > sysdeps/mach/hurd/readlinkat.c | 6 ++++-- > sysdeps/mach/hurd/sendfile64.c | 2 +- > 7 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/hurd/hurdioctl.c b/hurd/hurdioctl.c > index e9a6a7ea..59e6a5c1 100644 > --- a/hurd/hurdioctl.c > +++ b/hurd/hurdioctl.c > @@ -311,7 +311,7 @@ static int > siocgifconf (int fd, int request, struct ifconf *ifc) > { > error_t err; > - size_t data_len = ifc->ifc_len; > + mach_msg_type_number_t data_len = ifc->ifc_len; > char *data = ifc->ifc_buf; > > if (data_len <= 0) > diff --git a/hurd/hurdprio.c b/hurd/hurdprio.c > index dbeb272b..954d3987 100644 > --- a/hurd/hurdprio.c > +++ b/hurd/hurdprio.c > @@ -58,7 +58,7 @@ _hurd_priority_which_map (enum __priority_which which, int who, > int *oldpi = pi; > mach_msg_type_number_t oldpisize = pisize; > char *tw = 0; > - size_t twsz = 0; > + mach_msg_type_number_t twsz = 0; > err = __USEPORT (PROC, __proc_getprocinfo (port, pids[i], > &pi_flags, > &pi, &pisize, > diff --git a/hurd/lookup-retry.c b/hurd/lookup-retry.c > index 0d344026..8850c4fd 100644 > --- a/hurd/lookup-retry.c > +++ b/hurd/lookup-retry.c > @@ -162,7 +162,7 @@ __hurd_file_name_lookup_retry (error_t (*use_init_port) > { > char buf[1024]; > char *trans = buf; > - size_t translen = sizeof buf; > + mach_msg_type_number_t translen = sizeof buf; > err = __file_get_translator (*result, > &trans, &translen); > if (!err > diff --git a/hurd/xattr.c b/hurd/xattr.c > index f98e548c..48914bcf 100644 > --- a/hurd/xattr.c > +++ b/hurd/xattr.c > @@ -60,7 +60,7 @@ _hurd_xattr_get (io_t port, const char *name, void *value, size_t *size) > if (!strcmp (name, "translator")) > { > char *buf = value; > - size_t bufsz = value ? *size : 0; > + mach_msg_type_number_t bufsz = value ? *size : 0; > error_t err = __file_get_translator (port, &buf, &bufsz); > if (err) > return err; > @@ -144,7 +144,7 @@ _hurd_xattr_set (io_t port, const char *name, const void *value, size_t size, > { > /* Must make sure it's already there. */ > char *buf = NULL; > - size_t bufsz = 0; > + mach_msg_type_number_t bufsz = 0; > error_t err = __file_get_translator (port, &buf, &bufsz); > if (err) > return err; > diff --git a/sysdeps/mach/hurd/getcwd.c b/sysdeps/mach/hurd/getcwd.c > index fc5e78e7..f24b35b3 100644 > --- a/sysdeps/mach/hurd/getcwd.c > +++ b/sysdeps/mach/hurd/getcwd.c > @@ -117,7 +117,7 @@ __hurd_canonicalize_directory_name_internal (file_t thisdir, > int mount_point; > file_t newp; > char *dirdata; > - size_t dirdatasize; > + mach_msg_type_number_t dirdatasize; > int direntry, nentries; > > > diff --git a/sysdeps/mach/hurd/readlinkat.c b/sysdeps/mach/hurd/readlinkat.c > index dabdbb37..5bb8b753 100644 > --- a/sysdeps/mach/hurd/readlinkat.c > +++ b/sysdeps/mach/hurd/readlinkat.c > @@ -35,6 +35,7 @@ __readlinkat (int fd, const char *file_name, char *buf, size_t len) > char retryname[1024]; > file_t file; > char *rbuf = buf; > + mach_msg_type_number_t nread = len; > > file_stat = __file_name_lookup_at (fd, 0, file_name, O_NOLINK, 0); > if (file_stat == MACH_PORT_NULL) > @@ -59,15 +60,16 @@ __readlinkat (int fd, const char *file_name, char *buf, size_t len) > goto out; > } > > - err = __io_read (file, &rbuf, &len, 0, len); > + err = __io_read (file, &rbuf, &nread, 0, len); > __mach_port_deallocate (__mach_task_self (), file); > if (err) > goto out; > > + len = nread; > if (rbuf != buf) > { > memcpy (buf, rbuf, len); > - __vm_deallocate (__mach_task_self (), (vm_address_t) rbuf, len); > + __vm_deallocate (__mach_task_self (), (vm_address_t) rbuf, nread); > } > > > diff --git a/sysdeps/mach/hurd/sendfile64.c b/sysdeps/mach/hurd/sendfile64.c > index 658b0282..e36b9790 100644 > --- a/sysdeps/mach/hurd/sendfile64.c > +++ b/sysdeps/mach/hurd/sendfile64.c > @@ -35,7 +35,7 @@ __sendfile64 (int out_fd, int in_fd, off64_t *offset, size_t count) > which might blow if it's huge or address space is real tight. */ > > char *data = 0; > - size_t datalen = 0; > + mach_msg_type_number_t datalen = 0; > error_t err = HURD_DPORT_USE (in_fd, > __io_read (port, &data, &datalen, > offset ? *offset : (off_t) -1, > -- > 2.39.1 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.