From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 4F01F3858D1E for ; Sun, 12 Feb 2023 14:56:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F01F3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRDmR-0003MN-Sc; Sun, 12 Feb 2023 09:56:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=xH2ngpD+0Anyp4tO8aZQFSEu8bOIEKNsbEn+5ZB/EM0=; b=AuCYfz0JcGkmxgMelu0L lUujNmY7Di4hukqbOhuLBCycCP/Z7KTRXlOMxGoahx+QsMOhG+wrlPLkICPnEdw747QG4VuFO6Ss3 H5MRpbJSTLrriIZiSree2rYw9uvAKUIfkXMF25QlwxiM2gCc0Q1K5V2cGHCyuopyuMuKng6e8IeW/ Z49U+MkPxghwfKZDbtzln1a8nGjrQPU+9QJbhdh3/i8HJmhl+8UrNGQ1Zd+0zdc1F6U5h742nik7l r8mQryF3aabAbZPU9a2sxZ4e6lSWOTd5uxxgcz3loTTSlLLA3kLs8rTEcuQmRLuY74NFcOwIUpTnT dcT2RgyJ+rf2cQ==; Received: from lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr ([92.158.138.184] helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRDmM-0001Xt-Lv; Sun, 12 Feb 2023 09:56:39 -0500 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRDmL-004ngB-1P; Sun, 12 Feb 2023 15:56:33 +0100 Date: Sun, 12 Feb 2023 15:56:33 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz Subject: Re: [RFC PATCH glibc 4/12] hurd: Fix xattr error value Message-ID: <20230212145633.x5wa6sfqr4z4yjsu@begin> Mail-Followup-To: Sergey Bugaev , bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz References: <20230212111044.610942-1-bugaevc@gmail.com> <20230212111044.610942-5-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230212111044.610942-5-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied, thanks! Sergey Bugaev, le dim. 12 févr. 2023 14:10:35 +0300, a ecrit: > This does not seem like it is supposed to return negative error codes. > > Signed-off-by: Sergey Bugaev > --- > hurd/xattr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hurd/xattr.c b/hurd/xattr.c > index 48914bcf..5a0fc263 100644 > --- a/hurd/xattr.c > +++ b/hurd/xattr.c > @@ -68,7 +68,7 @@ _hurd_xattr_get (io_t port, const char *name, void *value, size_t *size) > { > if (buf != value) > __munmap (buf, bufsz); > - return -ERANGE; > + return ERANGE; > } > if (buf != value && bufsz > 0) > { > -- > 2.39.1 > > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.