From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 242D43858020 for ; Sun, 12 Feb 2023 15:15:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 242D43858020 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRE4G-00072Y-Kw; Sun, 12 Feb 2023 10:15:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=I+mpgg79nX/ewlmh8bJseCUAvoAv3DmDefUI15ww1kA=; b=R+5USUTPMdr8qBLOym/9 91iOLuOtmmEzqK5LvMSOoJYNPPA15adeLUPPijf76HdysdBKFMwRAc0RxEqPGrJm+UBCY48ATQqEz XHopQeWR1hd78H5GB/885B/IlFoOGKOCij3t2J5YQlVezytrml2HlvhihLf+BaTGk+7BVa/OJwBCS wW2o2sZtiSMw4n1cdfGqJNbws+yv8ElTJlog5a5fCTD7ufD69boed3YN+6IQ2t0axoD+zZ5Qse+nz iEMZO6EDdW/nEeNmJ4hN9SB+YoCsBd/NRD865360bZytvwYffdsvK8ZO8l2qugfCzYN7cdLG7/Yjr 1GD5I5tCacBKQw==; Received: from lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr ([92.158.138.184] helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRE4G-0007PS-02; Sun, 12 Feb 2023 10:15:04 -0500 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRE4C-004oqA-2B; Sun, 12 Feb 2023 16:15:00 +0100 Date: Sun, 12 Feb 2023 16:15:00 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz Subject: Re: [RFC PATCH glibc 10/12] hurd: Set up the basic tree for x86_64-gnu Message-ID: <20230212151500.obgujd27qck6xdu4@begin> Mail-Followup-To: Sergey Bugaev , bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz References: <20230212111044.610942-1-bugaevc@gmail.com> <20230212111044.610942-11-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230212111044.610942-11-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev, le dim. 12 févr. 2023 14:10:41 +0300, a ecrit: > And move pt-setup.c to the generic x86 tree. > > Signed-off-by: Sergey Bugaev > --- > sysdeps/mach/hurd/Implies | 1 + > sysdeps/mach/hurd/{i386 => x86}/htl/pt-setup.c | 4 ++-- > sysdeps/mach/hurd/x86_64/Implies | 2 ++ > sysdeps/mach/hurd/x86_64/htl/Implies | 3 +++ > sysdeps/mach/x86_64/Implies | 1 + > 5 files changed, 9 insertions(+), 2 deletions(-) > rename sysdeps/mach/hurd/{i386 => x86}/htl/pt-setup.c (97%) > create mode 100644 sysdeps/mach/hurd/x86_64/Implies > create mode 100644 sysdeps/mach/hurd/x86_64/htl/Implies > create mode 100644 sysdeps/mach/x86_64/Implies > > diff --git a/sysdeps/mach/hurd/Implies b/sysdeps/mach/hurd/Implies > index d2d5234c..e19dd1fd 100644 > --- a/sysdeps/mach/hurd/Implies > +++ b/sysdeps/mach/hurd/Implies > @@ -3,3 +3,4 @@ > gnu > # The Hurd provides a rough superset of the functionality of 4.4 BSD. > unix/bsd > +mach/hurd/htl > diff --git a/sysdeps/mach/hurd/i386/htl/pt-setup.c b/sysdeps/mach/hurd/x86/htl/pt-setup.c > similarity index 97% > rename from sysdeps/mach/hurd/i386/htl/pt-setup.c > rename to sysdeps/mach/hurd/x86/htl/pt-setup.c > index 94caed82..3abd92b2 100644 > --- a/sysdeps/mach/hurd/i386/htl/pt-setup.c > +++ b/sysdeps/mach/hurd/x86/htl/pt-setup.c > @@ -1,4 +1,4 @@ > -/* Setup thread stack. Hurd/i386 version. > +/* Setup thread stack. Hurd/x86 version. > Copyright (C) 2000-2023 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > @@ -22,7 +22,7 @@ > > #include > > -/* The stack layout used on the i386 is: > +/* The stack layout used on the x86 is: > > ----------------- > | ARG | > diff --git a/sysdeps/mach/hurd/x86_64/Implies b/sysdeps/mach/hurd/x86_64/Implies > new file mode 100644 > index 00000000..6b5e6f47 > --- /dev/null > +++ b/sysdeps/mach/hurd/x86_64/Implies > @@ -0,0 +1,2 @@ > +mach/hurd/x86 > +mach/hurd/x86_64/htl > diff --git a/sysdeps/mach/hurd/x86_64/htl/Implies b/sysdeps/mach/hurd/x86_64/htl/Implies > new file mode 100644 > index 00000000..1ae8f16e > --- /dev/null > +++ b/sysdeps/mach/hurd/x86_64/htl/Implies > @@ -0,0 +1,3 @@ > +mach/hurd/htl > +mach/hurd/x86/htl > +x86_64/htl Always remember to also try the 32bit build, I added this to your commit: diff --git a/sysdeps/mach/hurd/i386/htl/Implies b/sysdeps/mach/hurd/i386/htl/Implies index 7a0f99d772..fe3bd983b8 100644 --- a/sysdeps/mach/hurd/i386/htl/Implies +++ b/sysdeps/mach/hurd/i386/htl/Implies @@ -1,2 +1,3 @@ mach/hurd/htl +mach/hurd/x86/htl i386/htl Thanks! > diff --git a/sysdeps/mach/x86_64/Implies b/sysdeps/mach/x86_64/Implies > new file mode 100644 > index 00000000..da8291f4 > --- /dev/null > +++ b/sysdeps/mach/x86_64/Implies > @@ -0,0 +1 @@ > +mach/x86 > -- > 2.39.1 > > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.