From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 989573858D1E for ; Sun, 12 Feb 2023 15:18:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 989573858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRE83-0007Zr-6E; Sun, 12 Feb 2023 10:18:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=5rbqgWqF5Ein1vqhLxcZuhmWj6/IbUvfNx0YVud/P6g=; b=YJRJqWjbD7RsL4bHFh3j udfAkPy2CRK6yzFIUB/IVRdd0C8pdCn9mUgV0uEaCq7hWO44mrxMt3mUL6iamPL3HovQAhKvguKH/ hsExsZPfij6zf293Zv40crUqb21GJLsHCEk2OzRJh8UruWF0M7f22XvvCayXbIUxK86+mvafI8zaj dfXBjLfUsK7jGLYgCvnsw2eKLBrRE/TB/nF8P1s/yJLIn+MOghzJaZuz4nCKQJSNTND1UX8qxxNZa j02QUgwHzgDPzy9tqWRbK3CEy+QfsREpcyccjQewAtqLwkVwIWW6vA/cD+YjsaUMSaMjnZSuI7RrC 60xziXQKtr5X0g==; Received: from lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr ([92.158.138.184] helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRE82-0007o1-TN; Sun, 12 Feb 2023 10:18:58 -0500 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRE81-004p26-1t; Sun, 12 Feb 2023 16:18:57 +0100 Date: Sun, 12 Feb 2023 16:18:57 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz Subject: Re: [RFC PATCH glibc 12/12] C11 thrd: Downgrade the default alignment of mtx_t Message-ID: <20230212151857.c74uw45l2cssu5cl@begin> Mail-Followup-To: Sergey Bugaev , bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz References: <20230212111044.610942-1-bugaevc@gmail.com> <20230212111044.610942-13-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230212111044.610942-13-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev, le dim. 12 févr. 2023 14:10:43 +0300, a ecrit: > ..so that it can match the alignment of pthread_mutex_t on x86_64-gnu. I'd say rather make pthread_mutex_t aligned on long int, so we can possibly in the future put some pointers in it without breaking the ABI. > This likely breaks many other arches (if not all of them), though. > > Signed-off-by: Sergey Bugaev > --- > sysdeps/pthread/threads.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/pthread/threads.h b/sysdeps/pthread/threads.h > index 860d597d..207c1dee 100644 > --- a/sysdeps/pthread/threads.h > +++ b/sysdeps/pthread/threads.h > @@ -64,7 +64,7 @@ typedef __once_flag once_flag; > typedef union > { > char __size[__SIZEOF_PTHREAD_MUTEX_T]; > - long int __align __LOCK_ALIGNMENT; > + int __align __LOCK_ALIGNMENT; > } mtx_t; > > typedef union > -- > 2.39.1