From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 3DE2E3857365 for ; Sun, 12 Feb 2023 16:29:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DE2E3857365 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRFEb-0003gs-Qf; Sun, 12 Feb 2023 11:29:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=JGLDv2Xdw/NfxwriWwWTKpHnxHI5mNxDfTdXMB6ZsHA=; b=SdKZ5UNdPXSA/2cHs7f8 hx4thNN0rb07+CT0c65wIMMflYA0Xjlf1LS4aB7jWjcpY5UI53WdzxnaLcidhVJATKS1EEEKwCzDm FqX0SeI5SQUna9o+l4QAhyHl35MYDHYmfXiqvjxIqx1aSfFr+ur2/G3XwU84FDLcXfmQvDOC/YtWI /hoBzsflAnPpN7wuRxab2VGTlCuLiuE7pl/E2CCYdQ9hfGw0JlmqZw4Kc3VCZChgGvZZOW3bV4yyb eXufHRfDQci9479hrviYK+TxoHoZXJV3J403UjIFIBfwgsdfBqgiLfGD/xjMLtCIdhpaRe/ozpYIu VcOMqlo9sHr7gQ==; Received: from lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr ([92.158.138.184] helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRFEb-0006aw-J4; Sun, 12 Feb 2023 11:29:49 -0500 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRFEX-005A3S-13; Sun, 12 Feb 2023 17:29:45 +0100 Date: Sun, 12 Feb 2023 17:29:45 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz Subject: Re: [RFC PATCH glibc 12/12] C11 thrd: Downgrade the default alignment of mtx_t Message-ID: <20230212162945.3mxgzpxxxuza25jn@begin> Mail-Followup-To: Sergey Bugaev , bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz References: <20230212111044.610942-1-bugaevc@gmail.com> <20230212111044.610942-13-bugaevc@gmail.com> <20230212151857.c74uw45l2cssu5cl@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev, le dim. 12 févr. 2023 18:52:37 +0300, a ecrit: > On Sun, Feb 12, 2023 at 6:18 PM Samuel Thibault wrote: > > I'd say rather make pthread_mutex_t aligned on long int, so we can > > possibly in the future put some pointers in it without breaking the ABI. > > I honestly have 0 idea how it is not 8-aligned right now (nor how its > size is 32 and not like 56), given that this is its definition... > > no, strike that, I see that there are *two* versions of > struct___pthread_mutex.h, one in sysdeps/mach/hurd/htl/bits and the > other one in sysdeps/htl/bits/types, and the former one wins. The > latter one seems unused then, its only point was to confuse the hell > out of me. History is full of remnants. That's why one just has to take the time to clean things up and avoid leaving things behind oneself. It seems the a99155555c21 cleanup missed this one. Samuel