From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id A139C3858C00 for ; Sun, 12 Feb 2023 16:30:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A139C3858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRFFA-0003vz-Ce; Sun, 12 Feb 2023 11:30:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=E/C1SdowO2jFAXZQce2u/rZKCVHNpMo+R1RVLnq5wuY=; b=ExPWlgf8L0WTiqarKJYu z/sl7c2sGbVEKprhlfTHU6takDgQHVGrIV1X+2UYK+oFyo4XdUrquHoaHtlWTYqPQVxnNPCjbgkzz AeX19w0JbGm4/YEzvMWvZBALrbFSACXlmw5fjoVaA5HTGRWEmrjJUWSyLhUlQ/pgt7sqe5Ap/G5EQ Q2gLxPTZ0PntSuJCWeeuOsmpaflOAza2NLb9BsvPo/BAC9/52X/NuzuFJ2Wn+6XUXhaCuSIK3HoJ+ qYHP97JqSoB8Mgr5W1TCnSoT7XJTqbRss+tgSRIE94AMW6klxVLMqMZI480+n/PJPEIupXy0V1b27 oWoqwkEM3Lp2Eg==; Received: from lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr ([92.158.138.184] helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRFEt-0008US-K0; Sun, 12 Feb 2023 11:30:23 -0500 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pRFEs-005Avz-0F; Sun, 12 Feb 2023 17:30:06 +0100 Date: Sun, 12 Feb 2023 17:30:06 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz Subject: Re: [RFC PATCH hurd 6/12] hurd: Fix modes_t and speeds_t types on 64-bit Message-ID: <20230212163006.pkcrd3z64htmmsve@begin> Mail-Followup-To: Sergey Bugaev , bug-hurd@gnu.org, libc-alpha@sourceware.org, =?utf-8?Q?Fl=C3=A1vio?= Cruz References: <20230212111044.610942-1-bugaevc@gmail.com> <20230212111044.610942-7-bugaevc@gmail.com> <20230212150011.sjntfvmkxzuu6iqt@begin> <20230212152254.y7mxeu5vxh7lzetx@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev, le dim. 12 févr. 2023 19:13:58 +0300, a ecrit: > On Sun, Feb 12, 2023 at 6:22 PM Samuel Thibault wrote: > > I'd rather say drop the "long" part, to avoid having to pull the > > stdint.h header in. > > That's what I meant, yes. > > > Nowadays' BSD headers just use the int type, > > notably. > > So given that the Linux port has its own bits/termios.h, is it fine to > just modify the generic one inline, rather than creating a > Hurd-specific version? Yes. > The patch for that follows. > > Sergey > > -- >8 -- > > From 625b774141823a8f504cce8a92b9f45f5e6f050f Mon Sep 17 00:00:00 2001 > From: Sergey Bugaev > Date: Sun, 12 Feb 2023 19:08:57 +0300 > Subject: [PATCH] hurd: Fix tcflag_t and speed_t types on 64-bit > > These are supposed to stay 32-bit even on 64-bit systems. This matches > BSD and Linux, as well as how these types are already defined in > tioctl.defs > > Signed-off-by: Sergey Bugaev > --- > bits/termios.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/bits/termios.h b/bits/termios.h > index 4439c2f1..6a883ceb 100644 > --- a/bits/termios.h > +++ b/bits/termios.h > @@ -99,13 +99,13 @@ > `tcflag_t', `cc_t', `speed_t' and the `TC*' constants appropriately. */ > > /* Type of terminal control flag masks. */ > -typedef unsigned long int tcflag_t; > +typedef unsigned int tcflag_t; > > /* Type of control characters. */ > typedef unsigned char cc_t; > > /* Type of baud rate specifiers. */ > -typedef long int speed_t; > +typedef int speed_t; > > /* Terminal control structure. */ > struct termios > -- > 2.39.1 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.