From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id E40EE3858D32 for ; Sat, 18 Feb 2023 22:19:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E40EE3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x32a.google.com with SMTP id m22-20020a7bcb96000000b003e21e018039so435505wmi.3 for ; Sat, 18 Feb 2023 14:19:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KsKd0pLG34pR5XLWv/6+ODxjo5qq58uaubU45rJoU4A=; b=KisOQILcwQIoaycsmVMOP2hweewRm2aEW6CAvMAsJjmcCxvdKvitOiIhlEvzvZm+28 6PHduPrFV9n1dZWNnmHaya09p2HcICSqcBUlmuy66qBHAb3Oxw7WtXoRh19r3mGuUQzX oXxGTDvrVdShoNpyW+QBZj5M8KuQVdd5Cz8i/r9XXy/H643TsYu9+lB/hNLOXlnMI7o5 8wRkc5vpvdvgiKGJDM08pFbTTCjAYnz2ytnncZtzp6psjtWMNyU77G6WIrZ7FERCYcYz XDukRdPrOJprlQHVbrj2VDOz/t/dfP3ljZOXmp1ZBEXBzFgoQYJV7YsXvTq2pxpBPKPw I/Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KsKd0pLG34pR5XLWv/6+ODxjo5qq58uaubU45rJoU4A=; b=u1rJM6bP01pGtNeQF22cSXVXPBlOJQY/lggm1A8Gu+vKNEERPLiDArtcLpwiOyEXkn MKdE1PUWqA+PlUTW2IvODKYlDIQ57ah4ioLboCSZT9WOg8XrJSaBGEjDmFRMG71HUIpa FRa8QCjoSLlRcpDZKiWZlOksxKw8iiBM/u3EghA6OLqLcDpqUTpRAVkcS/jVHWqRdAvq 8DnBishKTvYeANq9fr6K16o24Eq7jSdnfKdzxp1XrFjxlBg+POsc/oUHlxYd8ejv9Nhb PgftfonYmjTcC3rVl7Kou9rhvpUL0WzRSCHwF5Mltkq6o6fdHt4pBDeaD/F0DPcKs4Wg bgeg== X-Gm-Message-State: AO0yUKUawixBnM4irB35jRI2XSZ2LJcN7IsX9JOOQczZ++bMX/4M3rnQ dyCngaUHxaK0b1MHpDZzzLpsK96bOhY= X-Google-Smtp-Source: AK7set+GGtPYBXyG1+qA/TL5fNnzlCqsyVsCRSKXNIGiBNa4gcAJoxLfAfbBD8xwWtvCxqwKYKdEFw== X-Received: by 2002:a05:600c:21c9:b0:3dd:1bd3:4f6d with SMTP id x9-20020a05600c21c900b003dd1bd34f6dmr4170862wmj.32.1676758760546; Sat, 18 Feb 2023 14:19:20 -0800 (PST) Received: from solpc.. (67.pool90-171-92.dynamic.orange.es. [90.171.92.67]) by smtp.gmail.com with ESMTPSA id l37-20020a05600c1d2500b003db0ad636d1sm6664405wms.28.2023.02.18.14.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Feb 2023 14:19:20 -0800 (PST) From: Joan Bruguera To: libc-alpha@sourceware.org, 87wn4iqh17.fsf@oldenburg.str.redhat.com Cc: adhemerval.zanella@linaro.org Subject: Re: [PATCH v3] elf: Restore ldconfig libc6 implicit soname logic [BZ #30125] Date: Sat, 18 Feb 2023 22:19:15 +0000 Message-Id: <20230218221915.3938215-1-joanbrugueram@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <87wn4iqh17.fsf@oldenburg.str.redhat.com> References: <87wn4iqh17.fsf@oldenburg.str.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> +$CC /dev/null -o $testroot/lib/libsomething.so.1.2.3 -shared > > This links against the system libc and not the libc under test. > > I'd suggest to build another module in elf/Makefile, have > $(objpfx)tst-ldconfig-no-soname.out depend on it. This way, it will be > built before the test script runs. Thanks, the .so's used in the test don't even need the stdlib anyway, they could be build with `-nostdlib`, but it's more elegant to build them in Makefile as you suggest. I have submitted a PATCH v4 with it. I also took the opportunity to test the complementary scenario, i.e. that ldconfig indeed creates a symlink for a .so with a soname, which expands coverage a bit and makes it easier to trust that the test for the original scenario is working correctly.