From: Samuel Thibault <samuel.thibault@gnu.org>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org,
"Flávio Cruz" <flaviocruz@gmail.com>
Subject: Re: [RFC PATCH 3/9] hurd: Fix xattr function return type
Date: Mon, 20 Feb 2023 00:34:42 +0100 [thread overview]
Message-ID: <20230219233442.cbhgmbhyjxirngj6@begin> (raw)
In-Reply-To: <20230218203717.373211-4-bugaevc@gmail.com>
Applied, thanks!
Sergey Bugaev, le sam. 18 févr. 2023 23:37:11 +0300, a ecrit:
> They all return int, not size_t.
>
> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
> sysdeps/mach/hurd/fsetxattr.c | 2 +-
> sysdeps/mach/hurd/lremovexattr.c | 2 +-
> sysdeps/mach/hurd/lsetxattr.c | 2 +-
> sysdeps/mach/hurd/removexattr.c | 2 +-
> sysdeps/mach/hurd/setxattr.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/sysdeps/mach/hurd/fsetxattr.c b/sysdeps/mach/hurd/fsetxattr.c
> index 71ee7599..dcc48fa0 100644
> --- a/sysdeps/mach/hurd/fsetxattr.c
> +++ b/sysdeps/mach/hurd/fsetxattr.c
> @@ -22,7 +22,7 @@
> #include <hurd/xattr.h>
> #include <hurd/fd.h>
>
> -ssize_t
> +int
> fsetxattr (int fd, const char *name, const void *value, size_t size, int flags)
> {
> error_t err;
> diff --git a/sysdeps/mach/hurd/lremovexattr.c b/sysdeps/mach/hurd/lremovexattr.c
> index 1d761e2d..cb6a1f8f 100644
> --- a/sysdeps/mach/hurd/lremovexattr.c
> +++ b/sysdeps/mach/hurd/lremovexattr.c
> @@ -22,7 +22,7 @@
> #include <hurd/xattr.h>
> #include <fcntl.h>
>
> -ssize_t
> +int
> lremovexattr (const char *path, const char *name)
> {
> error_t err;
> diff --git a/sysdeps/mach/hurd/lsetxattr.c b/sysdeps/mach/hurd/lsetxattr.c
> index 56c138dc..4e1e2de2 100644
> --- a/sysdeps/mach/hurd/lsetxattr.c
> +++ b/sysdeps/mach/hurd/lsetxattr.c
> @@ -22,7 +22,7 @@
> #include <hurd/xattr.h>
> #include <fcntl.h>
>
> -ssize_t
> +int
> lsetxattr (const char *path, const char *name, const void *value, size_t size,
> int flags)
> {
> diff --git a/sysdeps/mach/hurd/removexattr.c b/sysdeps/mach/hurd/removexattr.c
> index 128d0e01..fedc5370 100644
> --- a/sysdeps/mach/hurd/removexattr.c
> +++ b/sysdeps/mach/hurd/removexattr.c
> @@ -21,7 +21,7 @@
> #include <hurd.h>
> #include <hurd/xattr.h>
>
> -ssize_t
> +int
> removexattr (const char *path, const char *name)
> {
> error_t err;
> diff --git a/sysdeps/mach/hurd/setxattr.c b/sysdeps/mach/hurd/setxattr.c
> index be3b172b..ba6047cd 100644
> --- a/sysdeps/mach/hurd/setxattr.c
> +++ b/sysdeps/mach/hurd/setxattr.c
> @@ -21,7 +21,7 @@
> #include <hurd.h>
> #include <hurd/xattr.h>
>
> -ssize_t
> +int
> setxattr (const char *path, const char *name, const void *value, size_t size,
> int flags)
> {
> --
> 2.39.2
>
>
--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
next prev parent reply other threads:[~2023-02-20 10:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 20:37 [RFC PATCH 0/9] More x86_64-gnu glibc work Sergey Bugaev
2023-02-18 20:37 ` [RFC PATCH 1/9] hurd: Move thread state manipulation into _hurd_tls_new () Sergey Bugaev
2023-02-19 23:32 ` Samuel Thibault
2023-02-18 20:37 ` [RFC PATCH 2/9] hurd: Use proper integer types Sergey Bugaev
2023-02-19 23:33 ` Samuel Thibault
2023-02-18 20:37 ` [RFC PATCH 3/9] hurd: Fix xattr function return type Sergey Bugaev
2023-02-19 23:34 ` Samuel Thibault [this message]
2023-02-18 20:37 ` [RFC PATCH 4/9] hurd: Make timer_t pointer-sized Sergey Bugaev
2023-02-19 23:35 ` Samuel Thibault
2023-02-18 20:37 ` [RFC PATCH 5/9] hurd: Simplify init-first.c a bit Sergey Bugaev
2023-02-19 23:45 ` Samuel Thibault
2023-02-18 20:37 ` [RFC PATCH 6/9] mach: Use PAGE_SIZE Sergey Bugaev
2023-02-19 23:47 ` Samuel Thibault
2023-02-18 20:37 ` [RFC PATCH 7/9] hurd: Generalize init-first.c to support x86_64 Sergey Bugaev
2023-02-20 0:01 ` Samuel Thibault
2023-02-20 16:16 ` Sergey Bugaev
2023-02-20 17:10 ` Sergey Bugaev
2023-02-20 17:31 ` Samuel Thibault
2023-02-20 17:27 ` Noah Goldstein
2023-02-18 20:37 ` [RFC PATCH 8/9 gnumach] Add i386_fsgs_base_state Sergey Bugaev
2023-02-18 20:37 ` [RFC PATCH 9/9] hurd, htl: Add some more x86_64-specific code Sergey Bugaev
2023-02-20 0:30 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230219233442.cbhgmbhyjxirngj6@begin \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=bugaevc@gmail.com \
--cc=flaviocruz@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).