From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 45DBD385842B for ; Fri, 24 Feb 2023 01:08:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45DBD385842B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVMZH-0000Aw-Pa; Thu, 23 Feb 2023 20:08:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=H/ij6bLjriduswpE//oXJaVMBuwLyxiaJeELSgUUbpA=; b=SrTTdm73lXlSuui6DPAm gWiSkTaLhS7c1DQc0o9K90itLB4WMRodPhnNFSJHqY4dYnC3HU8rJTBw15n+9NFj7fFJZ4d/RSwtv +4nU+TxeLLNt6rNAqJ+R1lT4oMLtfIKH9Jkm38oswqCfaor7VVxpukLZTyhUvqYJV+Z227GvSh4wa 1TYqBtPfFF1u0WeckToy9Vm7nYCRxfSdOER8V8/r3278RDQ6SQcCqmMlmMRsprMMynBawTmtL4nwH S4EgoFe6AoWFyKJQfjsgdgfrEoJe6Gfm6jSZqyW3Uu5a8fmMennJ4ZpsUQmdet2xYBNUKMe0OWLBK rio1aZe09cgitw==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVMZH-0005nc-FP; Thu, 23 Feb 2023 20:08:11 -0500 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pVMZF-00Dndr-0o; Fri, 24 Feb 2023 02:08:09 +0100 Date: Fri, 24 Feb 2023 02:08:09 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org Subject: Re: [PATCH v2 1/4] hurd: Simplify init-first.c further Message-ID: <20230224010809.4ffpyq4qvy5qtoc2@begin> Mail-Followup-To: Sergey Bugaev , bug-hurd@gnu.org, libc-alpha@sourceware.org References: <20230221211932.296459-1-bugaevc@gmail.com> <20230221211932.296459-2-bugaevc@gmail.com> <20230222232646.sc3l7rec2wpalpxy@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev, le jeu. 23 févr. 2023 16:54:05 +0300, a ecrit: > And from what I remember from building glibc on the Hurd > itself back in 2021, make check takes a very long time and either > never really completes or brings the system into some weird state. Some checks pose problem indeed, see the "unsupported" lines in debian's debian/testsuite-xfail-debian.mk > If you're able to run make check on your end, please do so (but wait > until I send v3 with the changes you've requested below). I'll let it run through the night. > Are there specific tests for the various combinations of startup > variants? (shared vs static, args already on the stack vs not, exec > server present vs not) Basically it's the elf/ directory that tests things. I don't know which ones would exactly test what you'd want, there are various tests for various situations. > Instead of returning, _hurd_startup invokes a callback (doinit) that > (eventually) just sets the stack pointer to point to this data (so it > now is on the top of the stack, just as _start1 expects) and jumps to > _hurd_stack_setup's caller (i.e. to _start). Ah, ok, I had misunderstood and I hadn't really dived into the code. I thought _hurd_startup was eventually calling main() itself, but actually no it's sorta-returning to _start, but lower in the stack. Your current comments are enough, I was just stuck with older assumptions with the old stack switching code. Thanks! Samuel