From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from forward101o.mail.yandex.net (forward101o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::601]) by sourceware.org (Postfix) with ESMTPS id 5ED6D385840F for ; Fri, 24 Feb 2023 16:54:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5ED6D385840F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=yandex.ru Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yandex.ru Received: from sas1-61ab5dc724a3.qloud-c.yandex.net (sas1-61ab5dc724a3.qloud-c.yandex.net [IPv6:2a02:6b8:c08:162d:0:640:61ab:5dc7]) by forward101o.mail.yandex.net (Yandex) with ESMTP id DB470369BE01 for ; Fri, 24 Feb 2023 19:54:09 +0300 (MSK) Received: by sas1-61ab5dc724a3.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id 7sTr1tFbZqM1-58jGjhiH; Fri, 24 Feb 2023 19:54:09 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1677257649; bh=nZihGjoaGJvHThZq1CM+FMCZNvKR6LheeR/xgcK1we4=; h=Message-Id:Date:In-Reply-To:Cc:Subject:References:To:From; b=j5EKuednmTB3SvxW8oU/BbLiJcWlSr7AMmq3truYdNAZ7gLmlY7CzCOjyEJVoGgU0 wb3knzxMmXXqWVefkoqw3uWQTrUAkKQ7MYffHRSlR6bDj5CU8NXPs0mhY090Nkd1Ub hSuIpbMxqefJveQ2vAueAYBT5nlIPxX5CBnhqZcA= Authentication-Results: sas1-61ab5dc724a3.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru From: Stas Sergeev To: libc-alpha@sourceware.org Cc: Stas Sergeev Subject: [PATCH 1/2] elf/dl-open: fix audit wrt RTLD_NOLOAD [BZ #30127] Date: Fri, 24 Feb 2023 21:53:59 +0500 Message-Id: <20230224165400.3417104-2-stsp2@yandex.ru> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230224165400.3417104-1-stsp2@yandex.ru> References: <20230224165400.3417104-1-stsp2@yandex.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Currently dlmopen() does not allow to load objects into an audit namespace. But the RTLD_NOLOAD case was forgotten, so the too restrictive check prevents even getting a handle for an objects in an audit namespace. This patch fixes the problem by relaxing a check in case of RTLD_NOLOAD. Test-case on x86_64 revealed no regressions. Signed-off-by: Stas Sergeev --- elf/dl-open.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/elf/dl-open.c b/elf/dl-open.c index 91a2d8a538..c7ce0396d3 100644 --- a/elf/dl-open.c +++ b/elf/dl-open.c @@ -864,7 +864,8 @@ no more namespaces available for dlmopen()")); DL_NNS is 1 and so any NSID != 0 is invalid. */ || DL_NNS == 1 || GL(dl_ns)[nsid]._ns_nloaded == 0 - || GL(dl_ns)[nsid]._ns_loaded->l_auditing)) + || (GL(dl_ns)[nsid]._ns_loaded->l_auditing && + !(mode & RTLD_NOLOAD)))) _dl_signal_error (EINVAL, file, NULL, N_("invalid target namespace in dlmopen()")); -- 2.37.2