From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1BE973858D33 for ; Thu, 2 Mar 2023 08:30:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1BE973858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677745825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xJS50AocINkEfCMu/3+1Qwnit1uokQCW/HWirDYxRTU=; b=JqcliZHWOwgJyc7cLNnaTwoL5pbWO1I5UPQlPWjNa8u1TKneha70uk4GvqVXo0iryX7KDn rnHjNZc5Hk/zF5iLzaDjhBM81gDm+nqhwLmZX6+ad3nt7QN7pOCcPCW+jwj2GI52kfo2+N AB57GMHmV7wL0KEBmIZWJBzNCcKptXY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-516-AUcO4t2fP12C89RVetmVFQ-1; Thu, 02 Mar 2023 03:30:22 -0500 X-MC-Unique: AUcO4t2fP12C89RVetmVFQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F34683C10233; Thu, 2 Mar 2023 08:30:21 +0000 (UTC) Received: from localhost (unknown [10.39.192.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE0B7492C3E; Thu, 2 Mar 2023 08:30:20 +0000 (UTC) Date: Thu, 2 Mar 2023 08:30:20 +0000 From: "Richard W.M. Jones" To: Eric Blake Cc: Sam James , Carlos O'Donell via Libc-alpha , autoconf@gnu.org, c-std-porting@lists.linux.dev, Zack Weinberg , David Seifert , Gentoo Toolchain , Arsen =?utf-8?Q?Arsenovi=C4=87?= , Paul Eggert , berrange@redhat.com, Daiki Ueno Subject: Re: On time64 and Large File Support Message-ID: <20230302083020.GH7636@redhat.com> References: <20230301223859.chl5o3bedqckf3tx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230301223859.chl5o3bedqckf3tx@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 01, 2023 at 04:38:59PM -0600, Eric Blake wrote: > [replying to the original post, because I'm not sure where else in the > more recent activity on this thread would be more appropriate] > > On Fri, Nov 11, 2022 at 08:38:18AM +0000, Sam James wrote: > > Hi all, > > > > In Gentoo, we've been planning out what we should do for time64 on glibc [0] > > and concluded that we need some support in glibc for a newer option. I'll outline > > why below. > > > ... > > > > Indeed, the gnulib version of change #2 is exactly how we ended up with > > wget/gnutls breaking [1]. I feel this shows that the only approach > > "supported" by glibc right now is untenable. > > > [1] https://bugs.gentoo.org/828001 > > Now Fedora is also being hit by the gnutls ABI change due to time_t in > public interfaces being silently changed. From an IRC conversation I > had with Dan Berrange and Rich Jones (I think Rich mean i686 below): > > rjones (IRC): oh wow, the certificates created on i696 are not quite right ..... > Validity: > Not Before: Sat Sep 05 00:23:57 UTC 2703 > Not After: Sun Sep 06 00:23:57 UTC 2703 > just a few years too early > i think this is looking like a gnutls regression, downgrading gnutls makes it work > ... > rjones (IRC): hmm, i'm beginning to think gnutls has been miscompiled by gcc > gnutls_x509_crt_get_activation_time inside the gnutls verification api returns garbage > but the very same call done from a demo program returns the right answer > ... > OMG, gnulib-- has silently changed gnutls to use 64-bit time_t > ...which is an ABI incompatibility because gnutls has public APIs which have time_t parameters > so apps talking to gnutls will expect 32-bit time_t, but gnutls is processing 64-bit time_t > this is utterly insane For context, we first noticed that qemu tests were failing on i686 with lots of TLS-related errors. qemu uses GnuTLS. eg: Summary of Failures: 124/658 qemu:unit / test-crypto-tlscredsx509 ERROR 2.42s killed by signal 6 SIGABRT 202/658 qemu:unit / test-io-channel-tls ERROR 1.47s killed by signal 6 SIGABRT 125/658 qemu:unit / test-crypto-tlssession ERROR 8.74s killed by signal 6 SIGABRT 32/658 qemu:qtest+qtest-aarch64 / qtest-aarch64/migration-test ERROR 92.96s killed by signal 6 SIGABRT 34/658 qemu:qtest+qtest-i386 / qtest-i386/migration-test ERROR 96.63s killed by signal 6 SIGABRT 37/658 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test ERROR 104.25s killed by signal 6 SIGABRT Dan Berrange investigated and found the ABI change in GnuTLS causing this, since GnuTLS headers export public interfaces using time_t. Which in turn is caused by a change in gnulib enabling _TIME_BITS=64 This seems to have started in GnuTLS 3.8.0. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top