From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id A65643858C53 for ; Sun, 19 Mar 2023 15:44:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A65643858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdvCU-00018u-70; Sun, 19 Mar 2023 11:44:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=nX3eHTmQdoyQk0Fi8x8/7mTmruf3cOvy8wyuu3IOF7A=; b=niA8iOi9KtG7MYdDOESE B6NfGSyJj16Jv405DFXUSMDVlqCc14OezcPFhuouZoqQR8tjllo2JadRrCgAeSoGLfInIJqLqQURS 2n6tIlAiKgCiuSON4Hdvc7ByuVTmj6pwZjgK1I0qMvz29u9FEdC6QBoOpUol80mSwTTr1Mz1gDX9U zmRpTLpEXpKbZc23mw2yOBDjjQh1UzZWRQE0qtTG3ueJr4GZaTSQlTwEZ6J0olnrTkxxRfs1rsf+5 kfJeRpgtzHqhW9r2UZpgltfI4l9nNfs+9PKM8wZ6+A7TBwSx55uVP/zXMyHx6/rUuWoJS6rKQ+wH9 Rua6WeXi+1Hdrw==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdvCT-0007E9-Q6; Sun, 19 Mar 2023 11:44:01 -0400 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pdvCR-00E6Jc-1O; Sun, 19 Mar 2023 16:43:59 +0100 Date: Sun, 19 Mar 2023 16:43:59 +0100 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [RFC PATCH glibc 33/34] hurd: Create abilist files for lib{mach,hurd}user Message-ID: <20230319154359.ocohqcseohuraihh@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-34-bugaevc@gmail.com> <20230319151943.6mo7bsaxz33774gw@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev, le dim. 19 mars 2023 18:39:20 +0300, a ecrit: > Yay! Can you believe just how glad I am to finally have completed it :D I think I do :) > > I don't have the time now to review the whole series, just a comment > > here: we don't really want to introduce abilist for lib{mach,hurd}user > > since their content will depend on the mach/hurd version glibc gets > > built against. > > But isn't accidental ABI breakage (or unintended ABI additions) > exactly what the abilist mechanism is designed to guard against? Yes, but glibc is not responsible for ABI breakage of hurd and mach interfaces, so it's not really responsible for testing them. > It doesn't even break your build (unlike -Werror) -- it's more of a > lint. ? I believe it does? > Well in any case, the abilists aren't essential. Freel free to drop > this commit (and remove lib{mach,hurd}user.abilist from the next one) > if that was the wrong call. Sure! Samuel