From: "Dmitry V. Levin" <ldv@altlinux.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] getlogin_r: fix missing fallback if loginuid is unset (bug 30235)
Date: Thu, 30 Mar 2023 14:33:54 +0300 [thread overview]
Message-ID: <20230330113354.GA32706@altlinux.org> (raw)
In-Reply-To: <mvm8rfesdgb.fsf@suse.de>
On Thu, Mar 30, 2023 at 01:09:24PM +0200, Andreas Schwab via Libc-alpha wrote:
> When /proc/self/loginuid is not set, we should still fall back to using
> the traditional utmp lookup, instead of failing right away.
> ---
> sysdeps/unix/sysv/linux/getlogin_r.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/getlogin_r.c b/sysdeps/unix/sysv/linux/getlogin_r.c
> index 879df85a16..4ae9a53503 100644
> --- a/sysdeps/unix/sysv/linux/getlogin_r.c
> +++ b/sysdeps/unix/sysv/linux/getlogin_r.c
> @@ -59,10 +59,7 @@ __getlogin_r_loginuid (char *name, size_t namesize)
> value of, (uid_t) -1, so check if that value is set and return early to
> avoid making unneeded nss lookups. */
> if (uid == (uid_t) -1)
> - {
> - __set_errno (ENXIO);
> - return ENXIO;
> - }
> + return -1;
>
> struct passwd pwd;
> struct passwd *tpwd;
LGTM, thanks.
--
ldv
prev parent reply other threads:[~2023-03-30 11:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 11:09 Andreas Schwab
2023-03-30 11:33 ` Dmitry V. Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330113354.GA32706@altlinux.org \
--to=ldv@altlinux.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).