Re: Wrong warning in open_catalog.c with trunk GCC?

[Jan-Benedict Glaw <jbglaw@lug-owl.de>]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

Hi Sam,

On Sat, 2023-04-01 20:18:26 +0100, Sam James <sam@gentoo.org> wrote:
> Jan-Benedict Glaw <jbglaw@lug-owl.de> writes:
> > With the CI builds, after supplying --disable-gcov to gcc-first, I see
> > this while building glibc:
[...]
> > open_catalog.c: In function ‘__open_catalog’:
> > open_catalog.c:64:11: error: pointer ‘old_buf’ may be used after ‘realloc’ [-Werror=use-after-free]
> >    64 |           free (old_buf);                                                     \
> >       |           ^~~~~~~~~~~~~~
> > open_catalog.c:86:15: note: in expansion of macro ‘ENOUGH’
> >    86 |               ENOUGH (len);
> >       |               ^~~~~~
> > open_catalog.c:61:13: note: call to ‘realloc’ here
> >    61 |       buf = realloc (buf, bufmax);                                            \
> >       |             ^~~~~~~~~~~~~~~~~~~~~
[...]
> 
> See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109170. When did you
> build your GCC 13? Just now or a week or two ago?

Not sure, but obviously from before that fix got committed. But nice
to see that others catch these early issues as well.

Thanks a lot!

Jan-Benedict

-- 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]