From: Samuel Thibault <samuel.thibault@gnu.org>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org
Subject: Re: [RFC PATCH gnumach 03/34] Make exception subcode a long
Date: Mon, 3 Apr 2023 00:45:57 +0200 [thread overview]
Message-ID: <20230402224557.3cmvy5ztbxr2n7fm@begin> (raw)
In-Reply-To: <20230319151017.531737-4-bugaevc@gmail.com>
Applied, thanks!
Sergey Bugaev, le dim. 19 mars 2023 18:09:46 +0300, a ecrit:
> On EXC_BAD_ACCESS, exception subcode is used to pass the faulting memory
> address, so it needs to be (at least) pointer-sized. Thus, make it into
> a long.
>
> This requires matching changes in glibc and the Hurd.
But the change doesn't affect 32bit glibc and hurd since
rpc_long_integer_t is really like integer_t there, right?
> ---
>
> NOTE: Most of this was a pretty mechanical change, but I'm not very sure
> I got the exc_subcode_proto right; please do check.
>
> doc/mach.texi | 4 ++--
> i386/i386/trap.c | 2 +-
> i386/i386/trap.h | 2 +-
> include/mach/exc.defs | 2 +-
> kern/exception.c | 40 ++++++++++++++++++++++++++++------------
> kern/exception.h | 6 +++---
> kern/thread.h | 2 +-
> 7 files changed, 37 insertions(+), 21 deletions(-)
>
> diff --git a/doc/mach.texi b/doc/mach.texi
> index 2c22fa38..fdc36d45 100644
> --- a/doc/mach.texi
> +++ b/doc/mach.texi
> @@ -4830,11 +4830,11 @@ argument set to @code{THREAD_EXCEPTION_PORT}.
> @node Exceptions
> @subsection Exceptions
>
> -@deftypefun kern_return_t catch_exception_raise (@w{mach_port_t @var{exception_port}}, @w{thread_t @var{thread}}, @w{task_t @var{task}}, @w{int @var{exception}}, @w{int @var{code}}, @w{int @var{subcode}})
> +@deftypefun kern_return_t catch_exception_raise (@w{mach_port_t @var{exception_port}}, @w{thread_t @var{thread}}, @w{task_t @var{task}}, @w{int @var{exception}}, @w{int @var{code}}, @w{long @var{subcode}})
> XXX Fixme
> @end deftypefun
>
> -@deftypefun kern_return_t exception_raise (@w{mach_port_t @var{exception_port}}, @w{mach_port_t @var{thread}}, @w{mach_port_t @var{task}}, @w{integer_t @var{exception}}, @w{integer_t @var{code}}, @w{integer_t @var{subcode}})
> +@deftypefun kern_return_t exception_raise (@w{mach_port_t @var{exception_port}}, @w{mach_port_t @var{thread}}, @w{mach_port_t @var{task}}, @w{integer_t @var{exception}}, @w{integer_t @var{code}}, @w{long_integer_t @var{subcode}})
> XXX Fixme
> @end deftypefun
>
> diff --git a/i386/i386/trap.c b/i386/i386/trap.c
> index 34ccb6a5..f7bd8e38 100644
> --- a/i386/i386/trap.c
> +++ b/i386/i386/trap.c
> @@ -628,7 +628,7 @@ void
> i386_exception(
> int exc,
> int code,
> - int subcode)
> + long subcode)
> {
> spl_t s;
>
> diff --git a/i386/i386/trap.h b/i386/i386/trap.h
> index d9df7afa..e82164d0 100644
> --- a/i386/i386/trap.h
> +++ b/i386/i386/trap.h
> @@ -40,7 +40,7 @@ void
> i386_exception(
> int exc,
> int code,
> - int subcode) __attribute__ ((noreturn));
> + long subcode) __attribute__ ((noreturn));
>
> extern void
> thread_kdb_return(void);
> diff --git a/include/mach/exc.defs b/include/mach/exc.defs
> index 94af828c..28638e2f 100644
> --- a/include/mach/exc.defs
> +++ b/include/mach/exc.defs
> @@ -44,4 +44,4 @@ routine exception_raise(
> task : mach_port_t;
> exception : integer_t;
> code : integer_t;
> - subcode : integer_t);
> + subcode : rpc_long_integer_t);
> diff --git a/kern/exception.c b/kern/exception.c
> index 1014b3ed..10435b5c 100644
> --- a/kern/exception.c
> +++ b/kern/exception.c
> @@ -85,9 +85,9 @@ boolean_t debug_user_with_kdb = FALSE;
>
> void
> exception(
> - integer_t _exception,
> - integer_t code,
> - integer_t subcode)
> + integer_t _exception,
> + integer_t code,
> + long_integer_t subcode)
> {
> ipc_thread_t self = current_thread();
> ipc_port_t exc_port;
> @@ -157,9 +157,9 @@ exception(
>
> void
> exception_try_task(
> - integer_t _exception,
> - integer_t code,
> - integer_t subcode)
> + integer_t _exception,
> + integer_t code,
> + long_integer_t subcode)
> {
> ipc_thread_t self = current_thread();
> task_t task = self->task;
> @@ -277,11 +277,17 @@ struct mach_exception {
> mach_msg_type_t codeType;
> integer_t code;
> mach_msg_type_t subcodeType;
> - integer_t subcode;
> + rpc_long_integer_t subcode;
> };
>
> #define INTEGER_T_SIZE_IN_BITS (8 * sizeof(integer_t))
> #define INTEGER_T_TYPE MACH_MSG_TYPE_INTEGER_T
> +#define RPC_LONG_INTEGER_T_SIZE_IN_BITS (8 * sizeof(rpc_long_integer_t))
> +#if defined(__x86_64__) && !defined(USER32)
> +#define RPC_LONG_INTEGER_T_TYPE MACH_MSG_TYPE_INTEGER_64
> +#else
> +#define RPC_LONG_INTEGER_T_TYPE MACH_MSG_TYPE_INTEGER_32
> +#endif
> /* in mach/machine/vm_types.h */
>
> mach_msg_type_t exc_port_proto = {
> @@ -304,6 +310,16 @@ mach_msg_type_t exc_code_proto = {
> /* msgt_unused = */ 0
> };
>
> +mach_msg_type_t exc_subcode_proto = {
> + /* msgt_name = */ RPC_LONG_INTEGER_T_TYPE,
> + /* msgt_size = */ RPC_LONG_INTEGER_T_SIZE_IN_BITS,
> + /* msgt_number = */ 1,
> + /* msgt_inline = */ TRUE,
> + /* msgt_longform = */ FALSE,
> + /* msgt_deallocate = */ FALSE,
> + /* msgt_unused = */ 0
> +};
> +
> /*
> * Routine: exception_raise
> * Purpose:
> @@ -329,9 +345,9 @@ exception_raise(
> ipc_port_t dest_port,
> ipc_port_t thread_port,
> ipc_port_t task_port,
> - integer_t _exception,
> - integer_t code,
> - integer_t subcode)
> + integer_t _exception,
> + integer_t code,
> + long_integer_t subcode)
> {
> ipc_thread_t self = current_thread();
> ipc_thread_t receiver;
> @@ -521,7 +537,7 @@ exception_raise(
> exc->exception = _exception;
> exc->codeType = exc_code_proto;
> exc->code = code;
> - exc->subcodeType = exc_code_proto;
> + exc->subcodeType = exc_subcode_proto;
> exc->subcode = subcode;
>
> /*
> @@ -725,7 +741,7 @@ exception_raise(
> exc->exception = _exception;
> exc->codeType = exc_code_proto;
> exc->code = code;
> - exc->subcodeType = exc_code_proto;
> + exc->subcodeType = exc_subcode_proto;
> exc->subcode = subcode;
>
> ipc_mqueue_send_always(kmsg);
> diff --git a/kern/exception.h b/kern/exception.h
> index 55902dd1..36138da8 100644
> --- a/kern/exception.h
> +++ b/kern/exception.h
> @@ -26,13 +26,13 @@ extern void
> exception(
> integer_t _exception,
> integer_t code,
> - integer_t subcode) __attribute__ ((noreturn));
> + long_integer_t subcode) __attribute__ ((noreturn));
>
> extern void
> exception_try_task(
> integer_t _exception,
> integer_t code,
> - integer_t subcode) __attribute__ ((noreturn));
> + long_integer_t subcode) __attribute__ ((noreturn));
>
> extern void
> exception_no_server(void) __attribute__ ((noreturn));
> @@ -44,7 +44,7 @@ exception_raise(
> ipc_port_t task_port,
> integer_t _exception,
> integer_t code,
> - integer_t subcode) __attribute__ ((noreturn));
> + long_integer_t subcode) __attribute__ ((noreturn));
>
> extern kern_return_t
> exception_parse_reply(ipc_kmsg_t kmsg);
> diff --git a/kern/thread.h b/kern/thread.h
> index f8989f45..3485f6af 100644
> --- a/kern/thread.h
> +++ b/kern/thread.h
> @@ -190,7 +190,7 @@ struct thread {
> struct ipc_port *port;
> int exc;
> int code;
> - int subcode;
> + long subcode;
> } exception;
> void *other; /* catch-all for other state */
> } saved;
> --
> 2.39.2
>
--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.
next prev parent reply other threads:[~2023-04-02 22:45 UTC|newest]
Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 15:09 [RFC PATCH 00/34] The rest of the x86_64-gnu port Sergey Bugaev
2023-03-19 15:09 ` [RFC PATCH gnumach 01/34] Add i386_fsgs_base_state Sergey Bugaev
2023-04-02 22:43 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH gnumach 02/34] Remove bootstrap.defs Sergey Bugaev
2023-04-02 22:43 ` Samuel Thibault
2023-04-03 9:39 ` Sergey Bugaev
2023-03-19 15:09 ` [RFC PATCH gnumach 03/34] Make exception subcode a long Sergey Bugaev
2023-04-02 22:45 ` Samuel Thibault [this message]
2023-04-03 9:32 ` Sergey Bugaev
2023-04-06 2:11 ` Flávio Cruz
2023-04-10 23:52 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 04/34] hurd: " Sergey Bugaev
2023-04-02 22:52 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 05/34] hurd: Remove __hurd_threadvar_stack_{offset,mask} Sergey Bugaev
2023-04-02 22:53 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 06/34] hurd: Swap around two function calls Sergey Bugaev
2023-04-02 22:54 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 07/34] hurd: Fix file name in #error Sergey Bugaev
2023-04-02 22:55 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 08/34] hurd: Disable O_TRUNC and FS_RETRY_MAGICAL in rtld Sergey Bugaev
2023-04-02 22:57 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 09/34] hurd: Fix _hurd_setup_sighandler () signature Sergey Bugaev
2023-04-02 22:58 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 10/34] stdio-common: Fix building when !IS_IN (libc) Sergey Bugaev
2023-04-02 23:01 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 11/34] mach, hurd: Drop __libc_lock_self0 Sergey Bugaev
2023-04-02 23:02 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 12/34] hurd: More 64-bit integer casting fixes Sergey Bugaev
2023-04-02 23:03 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 13/34] x86-64: Disable prefer_map_32bit_exec tunable on non-Linux Sergey Bugaev
2023-04-02 23:09 ` Samuel Thibault
2023-04-03 10:10 ` Sergey Bugaev
2023-04-03 19:02 ` H.J. Lu
2023-04-03 20:11 ` Sergey Bugaev
2023-03-19 15:09 ` [RFC PATCH glibc 14/34] hurd: Move rtld-strncpy-c.c out of mach/hurd/ Sergey Bugaev
2023-04-02 23:10 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 15/34] hurd: Use uintptr_t for register values in trampoline.c Sergey Bugaev
2023-04-02 23:13 ` Samuel Thibault
2023-03-19 15:09 ` [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64 Sergey Bugaev
2023-04-10 18:39 ` Samuel Thibault
2023-04-10 19:07 ` Sergey Bugaev
2023-04-10 19:21 ` Samuel Thibault
2023-04-10 18:58 ` Samuel Thibault
2023-04-10 19:13 ` Sergey Bugaev
2023-04-10 19:21 ` Samuel Thibault
2023-04-10 21:50 ` Sergey Bugaev
2023-04-10 22:23 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 17/34] hurd: Implement x86_64/intr-msg.h Sergey Bugaev
2023-04-10 18:41 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 18/34] hurd: Port trampoline.c to x86_64 Sergey Bugaev
2023-04-03 11:56 ` [PATCH v2 18.0/34] Alignment-respecting x86_64 trampoline.c Sergey Bugaev
2023-04-03 11:56 ` [PATCH v2 18.1/34] hurd: Do not declare local variables volatile Sergey Bugaev
2023-04-10 18:42 ` Samuel Thibault
2023-04-03 11:56 ` [PATCH v2 18.2/34] hurd: Port trampoline.c to x86_64 Sergey Bugaev
2023-04-10 19:04 ` Samuel Thibault
2023-04-10 21:33 ` Sergey Bugaev
2023-03-19 15:10 ` [RFC PATCH glibc 19/34] hurd: Move a couple of singal-related files to x86 Sergey Bugaev
2023-04-02 23:15 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 20/34] htl: Add tcb-offsets.sym for x86_64 Sergey Bugaev
2023-04-02 23:16 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 21/34] x86_64: Add rtld-stpncpy & rtld-strncpy Sergey Bugaev
2023-04-02 23:18 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 22/34] htl: Implement thread_set_pcsptp for x86_64 Sergey Bugaev
2023-04-02 23:19 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 23/34] elf: Stop including tls.h in ldsodefs.h Sergey Bugaev
2023-04-02 23:20 ` Samuel Thibault
2023-04-03 9:26 ` Sergey Bugaev
2023-04-10 21:26 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 24/34] hurd: Only check for TLS initialization inside rtld or in static builds Sergey Bugaev
2023-04-10 21:33 ` Samuel Thibault
2023-04-11 18:57 ` Samuel Thibault
2023-04-11 19:18 ` Samuel Thibault
2023-04-11 20:03 ` Samuel Thibault
2023-04-11 20:27 ` Sergey Bugaev
2023-04-11 21:23 ` Samuel Thibault
2023-04-12 8:36 ` Sergey Bugaev
2023-04-12 9:00 ` Samuel Thibault
2023-04-12 10:42 ` Sergey Bugaev
2023-04-12 10:45 ` Samuel Thibault
2023-04-12 17:18 ` Sergey Bugaev
2023-04-12 23:46 ` Samuel Thibault
2023-04-13 10:02 ` Sergey Bugaev
2023-04-13 10:10 ` Samuel Thibault
2023-04-13 12:17 ` Sergey Bugaev
2023-04-13 21:47 ` Samuel Thibault
2023-04-13 22:21 ` Samuel Thibault
2023-04-14 8:29 ` Sergey Bugaev
2023-04-14 8:36 ` Samuel Thibault
2023-04-14 8:53 ` Sergey Bugaev
2023-04-14 9:09 ` Samuel Thibault
2023-04-14 9:23 ` Sergey Bugaev
2023-04-14 9:31 ` Samuel Thibault
2023-04-17 7:16 ` Samuel Thibault
2023-04-14 17:34 ` Samuel Thibault
2023-04-14 19:52 ` Sergey Bugaev
2023-03-19 15:10 ` [RFC PATCH glibc 25/34] hurd: Improve reply port handling when exiting signal handlers Sergey Bugaev
2023-04-10 22:03 ` Samuel Thibault
2023-04-11 7:44 ` Sergey Bugaev
2023-04-11 20:15 ` Samuel Thibault
2023-04-11 20:35 ` Sergey Bugaev
2023-04-12 22:54 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 26/34] hurd: Remove __hurd_local_reply_port Sergey Bugaev
2023-04-10 22:07 ` Samuel Thibault
2023-04-10 22:35 ` Samuel Thibault
2023-04-11 8:00 ` Sergey Bugaev
2023-04-11 20:18 ` Samuel Thibault
2023-04-13 11:58 ` [RFC PATCH glibc v2 " Sergey Bugaev
2023-04-13 13:12 ` Samuel Thibault
2023-04-13 13:20 ` Sergey Bugaev
2023-04-13 21:28 ` Samuel Thibault
2023-04-14 17:33 ` Samuel Thibault
2023-04-14 20:29 ` Sergey Bugaev
2023-04-15 6:45 ` Samuel Thibault
2023-04-15 7:34 ` Sergey Bugaev
2023-04-15 7:42 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 27/34] hurd: Don't leak __hurd_reply_port0 Sergey Bugaev
2023-04-10 22:25 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 28/34] hurd: Implement _hurd_longjmp_thread_state for x86_64 Sergey Bugaev
2023-04-02 23:23 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 29/34] hurd: Add vm_param.h " Sergey Bugaev
2023-04-02 23:24 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 30/34] hurd: Implement longjmp " Sergey Bugaev
2023-03-19 15:10 ` [RFC PATCH glibc 31/34] hurd: Microoptimize _hurd_self_sigstate () Sergey Bugaev
2023-04-02 23:26 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 32/34] hurd: Implement sigreturn for x86_64 Sergey Bugaev
2023-04-03 11:47 ` [PATCH v2] " Sergey Bugaev
2023-03-19 15:10 ` [RFC PATCH glibc 33/34] hurd: Create abilist files for lib{mach,hurd}user Sergey Bugaev
2023-03-19 15:19 ` Samuel Thibault
2023-03-19 15:39 ` Sergey Bugaev
2023-03-19 15:43 ` Samuel Thibault
2023-03-19 15:10 ` [RFC PATCH glibc 34/34] hurd: Add expected abilist files for x86_64 Sergey Bugaev
2023-03-19 18:04 ` Florian Weimer
2023-03-19 20:14 ` [PATCH v2] " Sergey Bugaev
2023-03-20 6:30 ` Florian Weimer
2023-03-19 16:44 ` [RFC PATCH 00/34] The rest of the x86_64-gnu port Luca
2023-03-20 5:03 ` Flávio Cruz
2023-04-02 23:30 ` Samuel Thibault
2023-04-10 19:20 ` Samuel Thibault
2023-04-10 21:24 ` Sergey Bugaev
2023-04-10 21:27 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230402224557.3cmvy5ztbxr2n7fm@begin \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=bugaevc@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).