From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 8B7833858C83 for ; Sun, 2 Apr 2023 22:54:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B7833858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj6ax-0007Bh-42; Sun, 02 Apr 2023 18:54:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=N7ZfD+1rahM/pIhVTnbbcU8ImZHyjTMgVEhIk5kTdY0=; b=E6m5rM88/xJARDg3RNpO 1iBcGxo+bLgg6D5H4XOkHv+huhqXON65q8oDUa9UOfhntaSvcnHgclzHMOqinD5wyGMXyle+Xa9G5 0v7wRo1jyEOF5Kudmu3ul1mpIBqfB+xXjDvpvjv+9COKc37S7RW60QRQmuzsSLOv/Fv7mRaMzNkyU EFTtF9nokKqXQyU8w8sDYaAGxf595S6BYsgeSATaUlz7SiWhufPjW0YbM6Dvv0wSx7w9vSfQJsvvF zVR03l+1awGsHpw+6pcrSqeIVvRKJLUPK/hkf4pzNn7DoJVeEXXXvCYy/Ztnu6PYlC41/3tUGaNXc CtdDsaOBBG3oZg==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj6aw-0000P1-Tc; Sun, 02 Apr 2023 18:54:42 -0400 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pj6av-00Arvd-2x; Mon, 03 Apr 2023 00:54:41 +0200 Date: Mon, 3 Apr 2023 00:54:41 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [RFC PATCH glibc 06/34] hurd: Swap around two function calls Message-ID: <20230402225441.ebbeyvihtcnho7ev@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-7-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230319151017.531737-7-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied, thanks! Sergey Bugaev, le dim. 19 mars 2023 18:09:49 +0300, a ecrit: > ...to keep `sigexc' port initialization in one place, and match what the > comments say. > > No functional change. > > Signed-off-by: Sergey Bugaev > --- > hurd/hurdfault.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hurd/hurdfault.c b/hurd/hurdfault.c > index a81e7280..4340897d 100644 > --- a/hurd/hurdfault.c > +++ b/hurd/hurdfault.c > @@ -174,14 +174,14 @@ _hurdsig_fault_init (void) > err = __mach_port_allocate (__mach_task_self (), > MACH_PORT_RIGHT_RECEIVE, &sigexc); > assert_perror (err); > - err = __mach_port_allocate (__mach_task_self (), > - MACH_PORT_RIGHT_RECEIVE, &forward_sigexc); > + err = __mach_port_insert_right (__mach_task_self (), sigexc, > + sigexc, MACH_MSG_TYPE_MAKE_SEND); > assert_perror (err); > > /* Allocate a port to receive the exception msgs forwarded > from the proc server. */ > - err = __mach_port_insert_right (__mach_task_self (), sigexc, > - sigexc, MACH_MSG_TYPE_MAKE_SEND); > + err = __mach_port_allocate (__mach_task_self (), > + MACH_PORT_RIGHT_RECEIVE, &forward_sigexc); > assert_perror (err); > > /* Set the queue limit for this port to just one. The proc server will > -- > 2.39.2 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.