From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 787FE3858CDB for ; Sun, 2 Apr 2023 23:01:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 787FE3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj6hJ-0000Nh-3Z; Sun, 02 Apr 2023 19:01:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=4JLRuZgpHBGH2kXhuHoEvIwLsK911t65JBWOYOm071Q=; b=BWRizu5cc32SmP28n+A8 VHJbnYCsrT6pPvvyLLB3KweMzrK2gPf5EA3Q+T5eM/5fnKK08IDzWgcv+swiNge6pfi+CtjshMtWG Hqxgp7nhRSMZcYITh7uWnZ7Kd3OEGn+PRM8FcDItPSxacS1pru9xbI2QDBKaniaiEREqs5jRLElM4 HPzzQSNkCsuJkrbu4vMjq/znIJNUMby/eLz+Sr6hiTajU6/z7uVX07QgwAXKkh0T2HOGZuHncrA+Y ntyg6tQRciN3yv1Iqlz1AXBLzkANE3iwOscKhBpsCOKS4MwBXrvuKUEyh/K2c4RiaGE/mQK2vabQ9 MEeofAPOUH5I2Q==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj6hI-0006iV-FY; Sun, 02 Apr 2023 19:01:16 -0400 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pj6hH-00AsJ3-1W; Mon, 03 Apr 2023 01:01:15 +0200 Date: Mon, 3 Apr 2023 01:01:15 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [RFC PATCH glibc 10/34] stdio-common: Fix building when !IS_IN (libc) Message-ID: <20230402230115.smc4lfmstn55tpqi@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-11-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230319151017.531737-11-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied, thanks! Sergey Bugaev, le dim. 19 mars 2023 18:09:53 +0300, a ecrit: > In this case, _itoa_word () is already defined inline in the header (see > sysdeps/generic/_itoa.h), and the second definition causes an error. > > Signed-off-by: Sergey Bugaev > --- > stdio-common/_itoa.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/stdio-common/_itoa.c b/stdio-common/_itoa.c > index 27285193..3037b0f5 100644 > --- a/stdio-common/_itoa.c > +++ b/stdio-common/_itoa.c > @@ -157,6 +157,7 @@ const struct base_table_t _itoa_base_table[] attribute_hidden = > }; > #endif > > +#if IS_IN (libc) > char * > _itoa_word (_ITOA_WORD_TYPE value, char *buflim, > unsigned int base, int upper_case) > @@ -185,6 +186,7 @@ _itoa_word (_ITOA_WORD_TYPE value, char *buflim, > return buflim; > } > #undef SPECIAL > +#endif /* IS_IN (libc) */ > > > #if _ITOA_NEEDED > -- > 2.39.2 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.