From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1CC143858CDB for ; Sun, 2 Apr 2023 23:03:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CC143858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj6jg-0000hM-OG; Sun, 02 Apr 2023 19:03:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=YklANBNGiXqog/PtnrVXX8Pk2Y+qbcB3tv/Xhti9s9M=; b=C1fcIrCoGS5VIJpkzPRS xpGHnN9/HkhEqpeQlqCqoIvYedCAVMQDPk9tQHeuux1V+PxPyxfJmVz/28n9d5lk6WZ+O8v5bRTum EulDVTx23YmSCOsj0kCCKOL69EVWqB3y54vHcj3/1N49IiTnY7UZ3sUH2zy2IjpSt4zLjxiUS534t KhJMkPyRrXHVtTZ3PRgefY+UDAXXOOXzz4CwGWqaP8M3GNDRLKQV7QMNZCWTHYQIru8qFscPUube2 DSWv91y95OPIu4/E5jr1gjDzDuYm/Fg+eulSd23o+khHoz+KbLG2+k2aEaBE0UGyUz52Mdfi+ropF ebZPlVsYoo3X1Q==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj6jg-0007EX-Bv; Sun, 02 Apr 2023 19:03:44 -0400 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pj6jf-00AsSJ-1G; Mon, 03 Apr 2023 01:03:43 +0200 Date: Mon, 3 Apr 2023 01:03:43 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [RFC PATCH glibc 12/34] hurd: More 64-bit integer casting fixes Message-ID: <20230402230343.gdj3mwk7dzyx2qk5@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-13-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230319151017.531737-13-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied, thanks! Sergey Bugaev, le dim. 19 mars 2023 18:09:55 +0300, a ecrit: > Signed-off-by: Sergey Bugaev > --- > sysdeps/mach/hurd/ioctl.c | 4 ++-- > sysdeps/mach/hurd/x86/init-first.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sysdeps/mach/hurd/ioctl.c b/sysdeps/mach/hurd/ioctl.c > index 0f5de5d3..ab913a59 100644 > --- a/sysdeps/mach/hurd/ioctl.c > +++ b/sysdeps/mach/hurd/ioctl.c > @@ -149,10 +149,10 @@ __ioctl (int fd, unsigned long int request, ...) > Rather than pointing to the value, ARG is the value itself. */ > #ifdef MACH_MSG_TYPE_BIT > *t++ = io2mach_type (1, _IOTS (integer_t)); > - *(integer_t *) t = (integer_t) arg; > + *(integer_t *) t = (integer_t) (intptr_t) arg; > t = (void *) t + sizeof (integer_t); > #else > - *(integer_t *) p = (integer_t) arg; > + *(integer_t *) p = (integer_t) (intptr_t) arg; > p = (void *) p + sizeof (integer_t); > #endif > } > diff --git a/sysdeps/mach/hurd/x86/init-first.c b/sysdeps/mach/hurd/x86/init-first.c > index 6ca27155..48c330ec 100644 > --- a/sysdeps/mach/hurd/x86/init-first.c > +++ b/sysdeps/mach/hurd/x86/init-first.c > @@ -1,4 +1,4 @@ > -/* Initialization code run first thing by the ELF startup code. For i386/Hurd. > +/* Initialization code run first thing by the ELF startup code. For x86/Hurd. > Copyright (C) 1995-2023 Free Software Foundation, Inc. > This file is part of the GNU C Library. > > @@ -92,7 +92,7 @@ posixland_init (int argc, char **argv, char **envp) > static void > init (void **data) > { > - int argc = (int) *data; > + int argc = (int) (uintptr_t) *data; > char **argv = (void *) (data + 1); > char **envp = &argv[argc + 1]; > struct hurd_startup_data *d; > -- > 2.39.2 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.