From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 53B5E3858CDB for ; Sun, 2 Apr 2023 23:20:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 53B5E3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj6zt-0004F8-Sj; Sun, 02 Apr 2023 19:20:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=11t73YzuhoPk+2q9nfaF0K77RcxN0iskk5qhwbkdGEg=; b=b2I5UcigJ/yD3S78WGKg 0dkvCFp2W0SnhFifKz5+W9TODpphCsxw9CqxFZwoTgH2wkClOHQITEVXUZL79qczn4qLRqzdlaVjA 16NkLv54cUNvuuxMYR9YBFnmuZEDXNKm5nacT8+gGS9i1epnnpPWiw9s4XU7HEgC1Vh3W0wWG6B6a vLpRtTRe61SIu2dyFcYm9WcioEvM1aEcI14ntuG65XYzIVaGCohYGmIVYFbWcsFh14aF8TtYI22fJ bxlFq4B0z6/qNmKxfWBJiZbkx3b8/p2LJPbHwlOK6Oxd0lhDsliywhOhWGwdXiGcKtXfEE1wyqiZY 4Df5Sa30Ox4l3A==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj6zt-0000iE-Kw; Sun, 02 Apr 2023 19:20:29 -0400 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pj6zs-00AtV8-1o; Mon, 03 Apr 2023 01:20:28 +0200 Date: Mon, 3 Apr 2023 01:20:28 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [RFC PATCH glibc 23/34] elf: Stop including tls.h in ldsodefs.h Message-ID: <20230402232028.ub4vsrnhjcphah2z@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230319151017.531737-1-bugaevc@gmail.com> <20230319151017.531737-24-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230319151017.531737-24-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev, le dim. 19 mars 2023 18:10:06 +0300, a ecrit: > Nothing in there needs tls.h Ok but includers might be erroneously relying on it. Did you try to build various configurations, to make sure that this isn't breaking any? > > Signed-off-by: Sergey Bugaev > --- > sysdeps/generic/ldsodefs.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h > index c99dad77..5f21bc63 100644 > --- a/sysdeps/generic/ldsodefs.h > +++ b/sysdeps/generic/ldsodefs.h > @@ -38,7 +38,6 @@ > #include > #include > #include > -#include > #include > > __BEGIN_DECLS > -- > 2.39.2 >