From: Samuel Thibault <samuel.thibault@gnu.org>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, commit-hurd@gnu.org
Subject: Re: [PATCH] aio: Fix freeing memory
Date: Wed, 12 Apr 2023 20:06:46 +0200 [thread overview]
Message-ID: <20230412180646.vc6s6hfymo7m3fbl@begin> (raw)
In-Reply-To: <e1052673-0177-19a1-cd75-3a1bee2c289a@linaro.org>
Adhemerval Zanella Netto, le mer. 12 avril 2023 09:39:00 -0300, a ecrit:
> On 11/04/23 19:15, Samuel Thibault wrote:
> > The content of the pool array is initialized only until pool_size,
> > pointers between pool_size and pool_max_size were not initialized by the
> > realloc call in get_elem so they should not be freed.
> >
> > This fixes aio tests crashing at their termination on GNU/Hurd.
>
> LGTM, thanks.
>
> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Pushed, thanks!
Ah, only then I realize that I should have added your review tag, sorry!
Samuel
prev parent reply other threads:[~2023-04-12 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 22:15 Samuel Thibault
2023-04-12 12:39 ` Adhemerval Zanella Netto
2023-04-12 18:06 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412180646.vc6s6hfymo7m3fbl@begin \
--to=samuel.thibault@gnu.org \
--cc=adhemerval.zanella@linaro.org \
--cc=commit-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).