From: Joe Simmons-Talbott <josimmon@redhat.com>
To: libc-alpha@sourceware.org
Cc: Joe Simmons-Talbott <josimmon@redhat.com>
Subject: [PATCH v2 1/2] x86_64: Set the syscall register right before doing the syscall.
Date: Wed, 12 Apr 2023 17:11:03 -0400 [thread overview]
Message-ID: <20230412211104.2609738-2-josimmon@redhat.com> (raw)
In-Reply-To: <20230412211104.2609738-1-josimmon@redhat.com>
To make identifying syscalls easier during call tree analysis load the
syscall number just before performing the syscall.
---
sysdeps/unix/sysv/linux/x86_64/sysdep.h | 33 +++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/sysdeps/unix/sysv/linux/x86_64/sysdep.h b/sysdeps/unix/sysv/linux/x86_64/sysdep.h
index cfb51be8c5..800a56723f 100644
--- a/sysdeps/unix/sysv/linux/x86_64/sysdep.h
+++ b/sysdeps/unix/sysv/linux/x86_64/sysdep.h
@@ -250,12 +250,20 @@
(long int) resultvar; \
})
+#define MSTR_HELPER(x) #x
+#define MSTR(x) MSTR_HELPER(x)
+
#undef internal_syscall1
#define internal_syscall1(number, arg1) \
({ \
unsigned long int resultvar; \
TYPEFY (arg1, __arg1) = ARGIFY (arg1); \
register TYPEFY (arg1, _a1) asm ("rdi") = __arg1; \
+ if (__builtin_constant_p(number)) \
+ asm volatile ("movl $" MSTR(number) ", %%eax\n\t" \
+ : /* no outputs */ \
+ : "i" (number) \
+ : "eax"); \
asm volatile ( \
"syscall\n\t" \
: "=a" (resultvar) \
@@ -272,6 +280,11 @@
TYPEFY (arg1, __arg1) = ARGIFY (arg1); \
register TYPEFY (arg2, _a2) asm ("rsi") = __arg2; \
register TYPEFY (arg1, _a1) asm ("rdi") = __arg1; \
+ if (__builtin_constant_p(number)) \
+ asm volatile ("movl $" MSTR(number) ", %%eax\n\t" \
+ : /* no outputs */ \
+ : "i" (number) \
+ : "eax"); \
asm volatile ( \
"syscall\n\t" \
: "=a" (resultvar) \
@@ -290,6 +303,11 @@
register TYPEFY (arg3, _a3) asm ("rdx") = __arg3; \
register TYPEFY (arg2, _a2) asm ("rsi") = __arg2; \
register TYPEFY (arg1, _a1) asm ("rdi") = __arg1; \
+ if (__builtin_constant_p(number)) \
+ asm volatile ("movl $" MSTR(number) ", %%eax\n\t" \
+ : /* no outputs */ \
+ : "i" (number) \
+ : "eax"); \
asm volatile ( \
"syscall\n\t" \
: "=a" (resultvar) \
@@ -310,6 +328,11 @@
register TYPEFY (arg3, _a3) asm ("rdx") = __arg3; \
register TYPEFY (arg2, _a2) asm ("rsi") = __arg2; \
register TYPEFY (arg1, _a1) asm ("rdi") = __arg1; \
+ if (__builtin_constant_p(number)) \
+ asm volatile ("movl $" MSTR(number) ", %%eax\n\t" \
+ : /* no outputs */ \
+ : "i" (number) \
+ : "eax"); \
asm volatile ( \
"syscall\n\t" \
: "=a" (resultvar) \
@@ -332,6 +355,11 @@
register TYPEFY (arg3, _a3) asm ("rdx") = __arg3; \
register TYPEFY (arg2, _a2) asm ("rsi") = __arg2; \
register TYPEFY (arg1, _a1) asm ("rdi") = __arg1; \
+ if (__builtin_constant_p(number)) \
+ asm volatile ("movl $" MSTR(number) ", %%eax\n\t" \
+ : /* no outputs */ \
+ : "i" (number) \
+ : "eax"); \
asm volatile ( \
"syscall\n\t" \
: "=a" (resultvar) \
@@ -357,6 +385,11 @@
register TYPEFY (arg3, _a3) asm ("rdx") = __arg3; \
register TYPEFY (arg2, _a2) asm ("rsi") = __arg2; \
register TYPEFY (arg1, _a1) asm ("rdi") = __arg1; \
+ if (__builtin_constant_p(number)) \
+ asm volatile ("movl $" MSTR(number) ", %%eax\n\t" \
+ : /* no outputs */ \
+ : "i" (number) \
+ : "eax"); \
asm volatile ( \
"syscall\n\t" \
: "=a" (resultvar) \
--
2.39.2
next prev parent reply other threads:[~2023-04-12 21:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 13:30 [PATCH 0/2] x86_64: aarch64: Set call number just before syscall Joe Simmons-Talbott
2023-04-11 13:30 ` [PATCH 1/2] x86_64: Set the syscall register right before doing the syscall Joe Simmons-Talbott
2023-04-17 22:35 ` Noah Goldstein
2023-04-17 22:36 ` Noah Goldstein
2023-04-11 13:30 ` [PATCH 2/2] aarch64: " Joe Simmons-Talbott
2023-04-11 13:50 ` Florian Weimer
2023-04-11 14:15 ` Adhemerval Zanella Netto
2023-04-11 15:43 ` Szabolcs Nagy
2023-04-11 16:03 ` Florian Weimer
2023-04-11 16:39 ` Adhemerval Zanella Netto
2023-04-12 15:27 ` Joe Simmons-Talbott
2023-04-12 21:11 ` [PATCH v2 0/2] x86_64: aarch64: Set call number just before syscall Joe Simmons-Talbott
2023-04-12 21:11 ` Joe Simmons-Talbott [this message]
2023-04-12 21:11 ` [PATCH v2 2/2] aarch64: Set the syscall register right before doing the syscall Joe Simmons-Talbott
2023-04-17 15:34 ` [PATCH v3 0/2] x86_64: aarch64: Set call number just before syscall Joe Simmons-Talbott
2023-04-17 15:34 ` [PATCH v3 1/2] x86_64: Set the syscall register right before doing the syscall Joe Simmons-Talbott
2023-04-17 15:54 ` H.J. Lu
2023-04-17 16:00 ` Joe Simmons-Talbott
2023-04-17 18:38 ` H.J. Lu
2023-04-17 15:34 ` [PATCH v3 2/2] aarch64: " Joe Simmons-Talbott
2023-04-17 21:20 ` [PATCH v4 0/2] x86_64: aarch64: Set call number just before syscall Joe Simmons-Talbott
2023-04-17 21:20 ` [PATCH v4 1/2] x86_64: Set the syscall register right before doing the syscall Joe Simmons-Talbott
2023-04-17 21:20 ` [PATCH v4 2/2] aarch64: " Joe Simmons-Talbott
2023-04-18 12:57 ` Szabolcs Nagy
2023-04-18 19:33 ` Joe Simmons-Talbott
2023-04-19 13:58 ` [PATCH v5 0/3] x86_64: aarch64: Set call number just before syscall Joe Simmons-Talbott
2023-04-19 13:58 ` [PATCH v5 1/3] x86_64: Set the syscall register right before doing the syscall Joe Simmons-Talbott
2023-04-19 15:35 ` H.J. Lu
2023-04-19 15:48 ` Joe Simmons-Talbott
2023-04-19 13:58 ` [PATCH v5 2/3] aarch64: " Joe Simmons-Talbott
2023-04-19 14:56 ` Szabolcs Nagy
2023-04-19 15:21 ` Joe Simmons-Talbott
2023-04-19 13:58 ` [PATCH v5 3/3] nptl: Use direct syscall numbers in setxid Joe Simmons-Talbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412211104.2609738-2-josimmon@redhat.com \
--to=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).