From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=qaZ6=AE=gnu.org=samuel.thibault@sourceware.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
	by sourceware.org (Postfix) with ESMTPS id 724FE3858D32
	for <libc-alpha@sourceware.org>; Thu, 13 Apr 2023 21:28:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 724FE3858D32
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e])
	by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <samuel.thibault@gnu.org>)
	id 1pn4UD-0003lI-Di; Thu, 13 Apr 2023 17:28:09 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
	s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From:
	Date; bh=R7c4TY2/CR3Dt0Oq7vQ1Js/RakX9npc1NnFkxbbcBkg=; b=HNqOl+ZhdVU8Z7fxaVDE
	9AhYbGoOdmYVrUczsDogVDNsp1cfI3PUf7aPnLuCJ5E75HXWDJKZpqThGy0ncugblx3OQc0nCe0GV
	m5cooVZgV18PnHA1T1vICi63sgxWpmYmKzA5pNXbIm0ZLsMWkWf9SwknSXLX9EtQDtO+BAj9ukNHI
	BhFifLlfKW7tpqq+/hXKr6oshC0eGlpXmrZMPDGvcJE2kFGFpBKIbpsKXMmfTpZazVG/0fFiquCGg
	duao0pSR1ILCu09b35tnjoE7nxxKMfJdcLv5sKNi+at2jbb3Ipcm8Wk5LXimfJhi7DN4pneoKiMZ7
	rhaBiupiX2mEng==;
Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin)
	by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.90_1)
	(envelope-from <samuel.thibault@gnu.org>)
	id 1pn4UD-0003eN-0E; Thu, 13 Apr 2023 17:28:09 -0400
Received: from samy by begin with local (Exim 4.96)
	(envelope-from <samuel.thibault@gnu.org>)
	id 1pn4UB-003Mj2-29;
	Thu, 13 Apr 2023 23:28:07 +0200
Date: Thu, 13 Apr 2023 23:28:07 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Sergey Bugaev <bugaevc@gmail.com>
Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org
Subject: Re: [RFC PATCH glibc v2 26/34] hurd: Remove __hurd_local_reply_port
Message-ID: <20230413212807.54chg2eqiyb5rjlz@begin>
Mail-Followup-To: Sergey Bugaev <bugaevc@gmail.com>,
	libc-alpha@sourceware.org, bug-hurd@gnu.org
References: <20230411201845.oias7lryrvm3cck7@begin>
 <20230413115812.267158-1-bugaevc@gmail.com>
 <20230413131227.oiotppbcxrpwl7l2@begin>
 <CAN9u=Hdghzk5Uox3nh6kzrzKWzTB_wsrooR9GPRrFCDe7zXOXA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAN9u=Hdghzk5Uox3nh6kzrzKWzTB_wsrooR9GPRrFCDe7zXOXA@mail.gmail.com>
Organization: I am not organized
User-Agent: NeoMutt/20170609 (1.8.3)
X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

Hello,

Sergey Bugaev, le jeu. 13 avril 2023 16:20:50 +0300, a ecrit:
> On Thu, Apr 13, 2023 at 4:12 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
>     at ../sysdeps/mach/hurd/dl-sysdep.c:241
> > 241       __mig_dealloc_reply_port (MACH_PORT_NULL);
> 
> Uhh, who deallocs a reply port like that :| You can't pass random crap
> into __mig_dealloc_reply_port and rely on its particular
> implementation, which *happened* to deallocate the current port.
> 
> Apparently FATAL_PREPARE in dl-sysdep.h is also defined to do the same.
> 
> I'd rather fix these both to do
> __mig_dealloc_reply_port (__mig_get_reply_port ());

That looks reasonable to me, yes.

Samuel