From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 71D383858D20 for ; Fri, 14 Apr 2023 09:12:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 71D383858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnFTc-0002xd-5v; Fri, 14 Apr 2023 05:12:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=1l/AJH2iLtP0kBBfEqbI2o8eLXkctBSDvz6XDEl1ARc=; b=NCKuLn4WB8x9oHif+Vep bkRseJBMIQ7gDXLeyp2TIpeS9tEfO906qQbDbnuxkHauhB2EGj29bzOGnPHo5xEwliIaC4HUxFjo7 W9oeM8PIz1k7JOsPcZtNZx12QNB9Gj3nxcBh29G9gCyUkw4lh3pYchjAERvyHnHW5WJFir+9DpjbC Td2RxiYnZYyfuA1KUW6hIhLg8PYlGCtBWRdmqPwuNVaqL6tA8yO2khRZe4Zv120fwWVO/9pzHJATs kLr1usv7orfAZF2nzSSS6Fgm044IZ3dUNEoPX6dZ28fF638J7nkw3nQrzcJGPCzeE+sGpHmEbr+59 VTa6mGu7tfHc5Q==; Received: from laptop-147-210-129-100.labri.fr ([147.210.129.100] helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnFTX-0003xm-S4; Fri, 14 Apr 2023 05:12:15 -0400 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1pnFRN-0093T4-35; Fri, 14 Apr 2023 11:09:57 +0200 Date: Fri, 14 Apr 2023 11:09:57 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [RFC PATCH glibc 24/34] hurd: Only check for TLS initialization inside rtld or in static builds Message-ID: <20230414090957.yh3cds6bzoxmiu55@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230412234657.ntztyz7iau55lcwt@begin> <20230413101058.wfmy7mb4dexsrbio@begin> <20230413214738.gz2rjnvjvwci7v4o@begin> <20230414083647.xz2iimas7jgzp4kr@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev via Libc-alpha, le ven. 14 avril 2023 11:53:43 +0300, a ecrit: > It's in _hurdsig_abort_rpcs, if the interrupt_operation call fails. > > Let's maybe not do that either? We're already making mach_msg seem to > have returned EINTR, which intr-msg knows how to handle. Mmm, yes, but we need to make *sure* we don't re-use the port and that it gets dropped at some point not too far, otherwise the server will stay stuck trying to reply. Managing to make the port a dead name seems a good way to me. Something like adding a send right to the port, then dropping the receive right. And making the __mig_dealloc_reply_port detect that case (if dropping the receive right returns KERN_INVALID_VALUE, it means it has indeed become a dead name for a send right, which one can drop instead). Again, in such code I don't think I can see the whole picture so it's testsuites that will find out the various cases. Samuel