From: Sergey Bugaev <bugaevc@gmail.com>
To: libc-alpha@sourceware.org, bug-hurd@gnu.org
Cc: Samuel Thibault <samuel.thibault@gnu.org>,
Sergey Bugaev <bugaevc@gmail.com>
Subject: [RFC PATCH 4/5] include/fcntl.h: Define O_IGNORE_CTTY
Date: Tue, 18 Apr 2023 01:58:56 +0300 [thread overview]
Message-ID: <20230417225857.2006561-5-bugaevc@gmail.com> (raw)
In-Reply-To: <20230417225857.2006561-1-bugaevc@gmail.com>
This internal definition makes it possible to use O_IGNORE_CTTY in
the glibc codebase unconditionally, no matter whether the current port
provides it or not (i.e. both on Hurd and on Linux). Along with the
definition, this adds a small guide on when O_IGNORE_CTTY is to be used.
The following commit will actually make use of O_IGNORE_CTTY
throughout the glibc codebase.
Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
---
include/fcntl.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/fcntl.h b/include/fcntl.h
index be435047..3de40827 100644
--- a/include/fcntl.h
+++ b/include/fcntl.h
@@ -33,6 +33,22 @@ extern int __openat_2 (int __fd, const char *__path, int __oflag);
extern int __openat64_2 (int __fd, const char *__path, int __oflag);
+/* Makes open () & friends slightly faster on the Hurd, but can only be used
+ (without altering user-visible behavior) when we're sure that the file
+ we're opening is not (at the moment) our controlling terminal. Use this
+ when:
+ - opening well-known files internally (utmp, nss db);
+ - opening files with user-specified names that can not reasonably be ttys
+ (sem_open, shm_open);
+ - opening new (previously unused) ttys (openpty).
+ Don't use this when:
+ - doing a general-purpose open () with a user-controlled path that could
+ well be "/dev/tty" (fopen). */
+#ifndef O_IGNORE_CTTY
+# define O_IGNORE_CTTY 0
+#endif
+
+
#if IS_IN (rtld)
# include <dl-fcntl.h>
#endif
--
2.39.2
next prev parent reply other threads:[~2023-04-17 22:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 22:58 [RFC PATCH 0/5] O_IGNORE_CTTY everywhere Sergey Bugaev
2023-04-17 22:58 ` [RFC PATCH 1/5] misc: Convert daemon () to GNU coding style Sergey Bugaev
2023-04-18 12:02 ` Adhemerval Zanella Netto
2023-04-18 13:48 ` Cristian Rodríguez
2023-04-18 18:49 ` Adhemerval Zanella Netto
2023-04-18 18:59 ` Sergey Bugaev
2023-04-17 22:58 ` [RFC PATCH 2/5] Use O_CLOEXEC in more places Sergey Bugaev
2023-04-18 12:05 ` Adhemerval Zanella Netto
2023-04-17 22:58 ` [RFC PATCH 3/5] hurd: Make dl-sysdep's open () cope with O_IGNORE_CTTY Sergey Bugaev
2023-04-17 22:58 ` Sergey Bugaev [this message]
2023-04-17 22:58 ` [RFC PATCH 5/5] Use O_IGNORE_CTTY where appropriate Sergey Bugaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230417225857.2006561-5-bugaevc@gmail.com \
--to=bugaevc@gmail.com \
--cc=bug-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).