From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 371E83858C53 for ; Mon, 17 Apr 2023 23:23:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 371E83858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poYCS-0007XQ-Hi; Mon, 17 Apr 2023 19:23:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=EH9txAJPv4MpfZuuJsH8Bc7qFkFNsLWZvxHtcL8aJnY=; b=Un5pc+nK4dq/4OqruUfM JZNy+YGwPyz3vDNWwHT+tDLCmp7no1gDHutpZYGMBEXoh7wsQ0w6sQJhd6X+CM2yTpA1Bl0DQJKO/ rBR9y/HOKi0/IDY1CdevfZm+tlG46BbyHgSctXFn1L14ruuhhMQerP/MalymC3FENjOhPxLLAWB9X 5DP/YxaWmSphL0RgoFxGU1UfrPXawUtFqXFdhRJJwa2HStnPz3ec3mj0Lh4BU9C/qOyvnR//FuOlX g5QGEcxj/ZPLVlgTZcPJDeEFIZaDetcSacPOnmSB0rIbr4OeO3oSvkpQfp49c/pSyYamWozU6jArS 1jmHTrf7b1in2g==; Received: from 2a01cb008c251f00de41a9fffe47ec49.ipv6.abo.wanadoo.fr ([2a01:cb00:8c25:1f00:de41:a9ff:fe47:ec49] helo=begin.home) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poYCS-0005yL-As; Mon, 17 Apr 2023 19:23:56 -0400 Received: from samy by begin.home with local (Exim 4.96) (envelope-from ) id 1poYCP-00AhDT-18; Tue, 18 Apr 2023 01:23:53 +0200 Date: Tue, 18 Apr 2023 01:23:53 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [PATCH 2/5] hurd: Microoptimize sigreturn Message-ID: <20230417232353.5w4fhwtgimjjif7r@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230414193700.542116-1-bugaevc@gmail.com> <20230414193700.542116-2-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230414193700.542116-2-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Sergey Bugaev, le ven. 14 avril 2023 22:36:57 +0300, a ecrit: > - struct hurd_sigstate *ss = _hurd_self_sigstate (); > + struct hurd_sigstate *ss; > + > + /* We know the sigstate must be initialized, That doesn't seem to be true, we get segfaults with this patch applied in these tests: ./htl/tst-kill6.test-result:FAIL: htl/tst-kill6 ./htl/tst-pt-tls2.test-result:FAIL: htl/tst-pt-tls2 #0 0x0105a7c2 in sigstate_is_global_rcv (ss=0x0) at hurdsig.c:183 183 && (ss->actions[0].sa_handler == SIG_IGN); (gdb) bt #0 0x0105a7c2 in sigstate_is_global_rcv (ss=0x0) at hurdsig.c:183 #1 __GI__hurd_sigstate_lock (ss=0x0) at hurdsig.c:192 #2 0x0108bb17 in __sigreturn (scp=0x2104bec) at ../sysdeps/mach/hurd/i386/sigreturn.c:94 #3 0x010602f6 in trampoline () from ./libc.so.0.3 Samuel