From: Sergey Bugaev <bugaevc@gmail.com>
To: libc-alpha@sourceware.org
Cc: bug-hurd@gnu.org, "Samuel Thibault" <samuel.thibault@gnu.org>,
"Adhemerval Zanella Netto" <adhemerval.zanella@linaro.org>,
"Cristian Rodríguez" <crrodriguez@opensuse.org>,
"Sergey Bugaev" <bugaevc@gmail.com>
Subject: [RFC PATCH v2 0/7] O_IGNORE_CTTY everywhere & misc fixes
Date: Wed, 19 Apr 2023 19:02:00 +0300 [thread overview]
Message-ID: <20230419160207.65988-1-bugaevc@gmail.com> (raw)
Changes since v1:
* Addressed nits
* Made improvements to daemon () as discussed
* Fixed std{in,out,err} mode in csu/check_fds.c
* Tweaked the comment on O_IGNORE_CTTY
But also, I found out that opening some internal files (specifically
I have noticed this about nsswitch.conf) still triggers the
term_getctty () RPC -- and that's because they're opened with
fopen (), not plain open (). Is there anything we can do abiut this?
I suppose there's no way we're could introduce a new fopen () mode
character just for this?
Even with the fopen-using callsites left out, not making ctty RPCs in
all the other cases is still a solid improvement.
Sergey
Sergey Bugaev (7):
misc: Convert daemon () to GNU coding style
misc: Ignore SIGHUP in daemon () while forking
Use O_CLOEXEC in more places (BZ #15722)
csu: Fix standard fds' mode
hurd: Make dl-sysdep's open () cope with O_IGNORE_CTTY
include/fcntl.h: Define O_IGNORE_CTTY
Use O_IGNORE_CTTY where appropriate
catgets/open_catalog.c | 4 +-
csu/check_fds.c | 6 +-
elf/dl-load.c | 2 +-
elf/dl-misc.c | 2 +-
elf/dl-profile.c | 3 +-
gmon/gmon.c | 7 ++-
iconv/gconv_cache.c | 3 +-
include/fcntl.h | 15 +++++
locale/loadarchive.c | 7 ++-
locale/loadlocale.c | 4 +-
login/openpty.c | 2 +-
login/utmp_file.c | 7 ++-
misc/daemon.c | 103 +++++++++++++++++++++-------------
nss/nss_db/db-open.c | 3 +-
rt/shm_open.c | 2 +-
shadow/lckpwdf.c | 2 +-
sysdeps/mach/hurd/dl-sysdep.c | 4 +-
sysdeps/mach/hurd/opendir.c | 2 +-
sysdeps/pthread/sem_open.c | 9 ++-
sysdeps/unix/bsd/getpt.c | 4 +-
20 files changed, 120 insertions(+), 71 deletions(-)
--
2.40.0
next reply other threads:[~2023-04-19 16:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 16:02 Sergey Bugaev [this message]
2023-04-19 16:02 ` [RFC PATCH v2 1/7] misc: Convert daemon () to GNU coding style Sergey Bugaev
2023-04-21 12:18 ` Adhemerval Zanella Netto
2023-04-22 11:47 ` Samuel Thibault
2023-04-19 16:02 ` [RFC PATCH v2 2/7] misc: Ignore SIGHUP in daemon () while forking Sergey Bugaev
2023-04-21 12:55 ` Adhemerval Zanella Netto
2023-04-19 16:02 ` [RFC PATCH v2 3/7] Use O_CLOEXEC in more places (BZ #15722) Sergey Bugaev
2023-04-21 12:55 ` Adhemerval Zanella Netto
2023-04-22 11:50 ` Samuel Thibault
2023-04-19 16:02 ` [RFC PATCH v2 4/7] csu: Fix standard fds' mode Sergey Bugaev
2023-04-19 19:13 ` Cristian Rodríguez
2023-04-19 19:40 ` Sergey Bugaev
2023-04-19 20:45 ` Adhemerval Zanella Netto
2023-04-19 21:16 ` Sergey Bugaev
2023-04-20 11:47 ` Adhemerval Zanella Netto
2023-04-20 12:06 ` Cristian Rodríguez
2023-04-20 15:13 ` Adhemerval Zanella Netto
2023-04-21 17:16 ` Paul Eggert
2023-04-19 16:02 ` [RFC PATCH v2 5/7] hurd: Make dl-sysdep's open () cope with O_IGNORE_CTTY Sergey Bugaev
2023-04-20 21:06 ` Samuel Thibault
2023-04-19 16:02 ` [RFC PATCH v2 6/7] include/fcntl.h: Define O_IGNORE_CTTY Sergey Bugaev
2023-04-19 16:02 ` [RFC PATCH v2 7/7] Use O_IGNORE_CTTY where appropriate Sergey Bugaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419160207.65988-1-bugaevc@gmail.com \
--to=bugaevc@gmail.com \
--cc=adhemerval.zanella@linaro.org \
--cc=bug-hurd@gnu.org \
--cc=crrodriguez@opensuse.org \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).