From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id 6245A385840A for ; Wed, 19 Apr 2023 16:02:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6245A385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x233.google.com with SMTP id l15so10268901ljq.8 for ; Wed, 19 Apr 2023 09:02:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681920155; x=1684512155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LxuAi8jCXgMCNgATqS3mARG4RgKjqe4DPkLlz4zCuYM=; b=ZLWUj6sayJO4zizTg+P9fsXS+pmPSgZhjsEfKW4k/NPaiFZNkpx+/+hsrXx17elj4K HW2vbvEVW1X/prNz4UXKSIebR/kIwUF1xAWTkK5fOyiO6RT0fx02PCd7wv+1Z4XDjvRG h0gCdxIomTP5HLbLwbihsVOatWERe58V/ToTAZ/IcTTM8e4FRHRJWwbtD8nzCwTAMmMy aTPB6OgosVd8GlLCX8BkqaUYtAvQkamF7wcLhPDS+0ui17Uj1R5Vbzpv9XvDP4HsZwUx s7OFxLOW9CFdPkKaQPj19MeSH2Ize9n7zlbFEbN/1SrmKbpbjB29le8tvwnMQm4aOBUh Vakw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681920155; x=1684512155; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LxuAi8jCXgMCNgATqS3mARG4RgKjqe4DPkLlz4zCuYM=; b=fSTa2KuIdtEn0przAbTFFNbVxnT3K4n46zzu7ijIvx/x4CbzjPYBtmkPFF+O7euhC3 OwL3p8pwIVrQlx6cvLfFrZEl9SG2TpZk7h/FTlQacFqJbvzGI1sWOlzsNTgUFi0+SPYJ YInkyBPjlw3H3n2awxi46csc6WQolKmzAuKC1Tyl5tcsMFs6YHxwBwVgEa4/IBRLUEge c5y0xOecllwRKv4ErTMPpWGNagitOkDpmE/Fk0SEZULszRGsg735nXMCFxhdRQRBxmjB Ut62oeVHHZcXrbPHt1m1fr6OMEQPj6oXLKvTV8FoIiDiJ4u1ySkx1NAW+o7ojGiaUV7q etUw== X-Gm-Message-State: AAQBX9c3Gw8j3PvnBufcsqkYfgbowOtr8F4xgm9F5iifl0iGpCqMiqFr 9HSC02M3fwfcA6gGUYN2A5DaXgidbvQ= X-Google-Smtp-Source: AKy350Yrubv+84xu5PVRJCCk3BYRm0/d2jb3D9DVKxR+yW24tAMk70PFbj7/ZSewJDFvIdPZL3BARA== X-Received: by 2002:a2e:9f44:0:b0:2a8:a07a:a46d with SMTP id v4-20020a2e9f44000000b002a8a07aa46dmr2046636ljk.33.1681920155001; Wed, 19 Apr 2023 09:02:35 -0700 (PDT) Received: from surface-pro-6.. ([194.190.106.50]) by smtp.gmail.com with ESMTPSA id l1-20020a2e7001000000b002a6007383a0sm2959663ljc.135.2023.04.19.09.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 09:02:33 -0700 (PDT) From: Sergey Bugaev To: libc-alpha@sourceware.org Cc: bug-hurd@gnu.org, Samuel Thibault , Adhemerval Zanella Netto , =?UTF-8?q?Cristian=20Rodr=C3=ADguez?= , Sergey Bugaev Subject: [RFC PATCH v2 4/7] csu: Fix standard fds' mode Date: Wed, 19 Apr 2023 19:02:04 +0300 Message-Id: <20230419160207.65988-5-bugaevc@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230419160207.65988-1-bugaevc@gmail.com> References: <20230419160207.65988-1-bugaevc@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: stdin is supposed to be readable, stdout and stderr writable. Otherwise, we get this: l-wx------. 1 root root 64 Apr 19 18:40 0 -> /dev/full lr-x------. 1 root root 64 Apr 19 18:40 1 -> /dev/null lr-x------. 1 root root 64 Apr 19 18:40 2 -> /dev/null Signed-off-by: Sergey Bugaev --- csu/check_fds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/csu/check_fds.c b/csu/check_fds.c index de6dd716..ca4812cd 100644 --- a/csu/check_fds.c +++ b/csu/check_fds.c @@ -90,7 +90,7 @@ __libc_check_standard_fds (void) is really paranoid but some people actually are. If /dev/null should happen to be a symlink to somewhere else and not the device commonly known as "/dev/null" we bail out. */ - check_one_fd (STDIN_FILENO, O_WRONLY | O_NOFOLLOW); - check_one_fd (STDOUT_FILENO, O_RDONLY | O_NOFOLLOW); - check_one_fd (STDERR_FILENO, O_RDONLY | O_NOFOLLOW); + check_one_fd (STDIN_FILENO, O_RDONLY | O_NOFOLLOW); + check_one_fd (STDOUT_FILENO, O_WRONLY | O_NOFOLLOW); + check_one_fd (STDERR_FILENO, O_WRONLY | O_NOFOLLOW); } -- 2.40.0