From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 6E5C93858D37 for ; Thu, 20 Apr 2023 21:06:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E5C93858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppbUF-0000hs-Rf; Thu, 20 Apr 2023 17:06:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=0/E5GQizbHWlbvbEQAUsmfTSAdJjSNlO3R0OFV4zLik=; b=Y3lglyApy8UVjH24Q3vX pYsgejUJqpSM2p+p17//bjZRsiddZiI7N5kUSsZMeLeE/a355XTwctOX8xnIlXb5fafLtezvm2wgi 3tJYpHU5KMIDhufGhjW705PulPPLnxRM5h/fkv71C3Mwyoz4RSpLTMlRVOI2QJ+vvx21wd1DSy+z1 mqHDTiFnKfMWJOUeEXP+qZPk7Re5WeaBLUfRHXC+punqGpmdUhnJfScGe3H6s+pxQRO/vTGobFBJ+ EnxE9hRLCjNM99MQbXLPf+OhBvEXGlg51QhrACOPlU/H+gu606LEY6tmV+9xsMbt5TRTpEmP8GOnH d1j/SMErxvWqbg==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin.home) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppbUF-0005fv-Di; Thu, 20 Apr 2023 17:06:39 -0400 Received: from samy by begin.home with local (Exim 4.96) (envelope-from ) id 1ppbUD-009YlB-2N; Thu, 20 Apr 2023 23:06:37 +0200 Date: Thu, 20 Apr 2023 23:06:37 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org, Adhemerval Zanella Netto , Cristian =?utf-8?Q?Rodr=C3=ADguez?= Subject: Re: [RFC PATCH v2 5/7] hurd: Make dl-sysdep's open () cope with O_IGNORE_CTTY Message-ID: <20230420210637.3e666pfj45ko3yub@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org, Adhemerval Zanella Netto , Cristian =?utf-8?Q?Rodr=C3=ADguez?= References: <20230419160207.65988-1-bugaevc@gmail.com> <20230419160207.65988-6-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230419160207.65988-6-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied, thanks! Sergey Bugaev, le mer. 19 avril 2023 19:02:05 +0300, a ecrit: > Signed-off-by: Sergey Bugaev > --- > sysdeps/mach/hurd/dl-sysdep.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/mach/hurd/dl-sysdep.c b/sysdeps/mach/hurd/dl-sysdep.c > index 2d595d00..6e167e12 100644 > --- a/sysdeps/mach/hurd/dl-sysdep.c > +++ b/sysdeps/mach/hurd/dl-sysdep.c > @@ -289,8 +289,8 @@ open_file (const char *file_name, int flags, > return MACH_PORT_NULL; > } > > - assert (!(flags & ~(O_READ | O_EXEC | O_CLOEXEC))); > - flags &= ~O_CLOEXEC; > + assert (!(flags & ~(O_READ | O_EXEC | O_CLOEXEC | O_IGNORE_CTTY))); > + flags &= ~(O_CLOEXEC | O_IGNORE_CTTY); > > startdir = _dl_hurd_data->portarray[file_name[0] == '/' > ? INIT_PORT_CRDIR : INIT_PORT_CWDIR]; > -- > 2.40.0 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.