From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 57A4C3858D32 for ; Mon, 24 Apr 2023 22:18:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 57A4C3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pr4W3-0008NT-Sv; Mon, 24 Apr 2023 18:18:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=u+J6zwdzYYdCTfCKC177H1FZUAQMPPsLDU7K0D6l4ow=; b=dZqgDyMgzrfhfBWcb0yj oN/bvLzT7SvYK7cswVInyQMSdBMBs6Cb1mw9ZXlI3D1SV58npm5T01Ma26OUIUadMWvbstaXew/Dn KI5U8QBZsuvNEawq9l6bRq/yv8Kl4Jc5hBmubuH8kWuSLPkOJxjWDZowjmYp1cSRdIPZeHl18OalC eZm/BjJu5zL3hBfdH76G6++h7AHIe6yehFpFkfnA/Q8nU4RPOKulowjmKOvKhxxrN52euDvsDM/zo IwG2IoSRsAwj7rxrq21qP73bDDQ4pSNyjLWvYwe73fMmItZrKlpzcuoRHi0lzk6yBvVz6Za4uEhBU /k5heScrX2kb3A==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin.home) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pr4W3-0000Oa-H5; Mon, 24 Apr 2023 18:18:35 -0400 Received: from samy by begin.home with local (Exim 4.96) (envelope-from ) id 1pr4Vz-008rju-2F; Tue, 25 Apr 2023 00:18:31 +0200 Date: Tue, 25 Apr 2023 00:18:31 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [PATCH v2 2/4] hurd: Implement MSG_CMSG_CLOEXEC Message-ID: <20230424221831.cwzw4e4lo5i3rzwi@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230423160548.126576-1-bugaevc@gmail.com> <20230423160548.126576-2-bugaevc@gmail.com> <20230424211009.3dbv745qz36vmkpi@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev, le mar. 25 avril 2023 00:35:58 +0300, a ecrit: > On Tue, Apr 25, 2023 at 12:10 AM Samuel Thibault > wrote: > > Applied, thanks! > > Thank you -- but I see you changed it to say "fds[j] | fd_flags". > > For one thing it would be nice of you to indicate that this was your > change, not mine, That change is not actually in this commit, but in the previous where I left fds[j] as it was. In this commit we just add | fd_flags. > because as things are it looks like I wrote that, > but I didn't. Linux docs (I was about to write "kernel docs", heh) > suggest this pattern: > > > it is recommended that you add a line between the last > > Signed-off-by header and yours, indicating the nature of your > > changes. While there is nothing mandatory about this, it seems like > > prepending the description with your mail and/or name, all enclosed > > in square brackets, is noticeable enough to make it obvious that you > > are responsible for last-minute changes. Example : > > > > Signed-off-by: Random J Developer > > [lucky@maintainer.example.org: struct foo moved from foo.c to foo.h] > > Signed-off-by: Lucky K Maintainer Ah, I didn't know about that style. > But on the technical side of things, I don't think we should take > whatever integer arrives in the message and use it as flags. We never > check it for sanity; who knows what might be there; Right. I have added the filtering, then. Yes, "& 0" looks odd, but I'd rather keep in code the documentation of how we believe it's supposed to work, for people to find it later whenever needed. Samuel