From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 2DA743858C50 for ; Sat, 29 Apr 2023 13:13:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DA743858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4effb818c37so1059319e87.3 for ; Sat, 29 Apr 2023 06:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682774036; x=1685366036; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QtVwqsqQuRS61th3GZO1nYlIJWswXNR9eE5lGLNdgm8=; b=YpDZGka5NJndezzdiAHmGA1znZZWWrjp85nePdoJoW+mrNw6CEJH8dSluqXIg4RgAd Q1vDayhBDMRA54adBFzIzaLmjsL9T7o1AFXapNCIx4fzksRWE4LiIWXmp+yCvjwq+qhv 17m9xmAKgzyBmOgAO6y8C72kjA1VmOQHyQHKyLrNgyP8kmNhwHa+0jasE5Pt5fM04pNV CgG1ZQzl8vDzbaXk/UltEz2EGLeGAM+MiSGkl3eowjzBESkAMfduuSv+OWGLkvitRj6s D4skwmM3W5+zbN+jRDGHKfjIQBSlTJQeHleIIHkvEZeB+UdV6jnNR3Bng1UTZVvwTv8q mP6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682774036; x=1685366036; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QtVwqsqQuRS61th3GZO1nYlIJWswXNR9eE5lGLNdgm8=; b=PPnQLBpYZIVKuhZDchVm4Cub+1ltk+neqcPLbPnUrQeVkJScHHAOnRevagDLBv3FMy LrdEFSOuGDIG870e8H1yfs4msdJoyBCWGMHwuWgXX+wktFEGJqGLBhNC4NnMvTjKMsbu MwStvVzhIISKC7QMYzcGZU6iCITHb6AcIs1p7JZbWARgxjDPflpRE08rrVc/DxJBGyMW jJ6jGzAoUUf6q8Q/AmMzKc8KsrUBvzvcFPRS5grwQFB75jbUIe8O8kPXVwAop0EVdIt1 YvI/LbIRi34aEJ5LyywWYwWgfXuCOtYZvFSNQwzGLlSWneMb/zRVcg+x6Ka7aJE+3uKx EpBg== X-Gm-Message-State: AC+VfDxffUtJPrLs5LTiPm9OKpQHj3+SRrIrRzzwv+mSQC6RgnxxR/5C zxoedHYSWUPrJXLxL/lPdk+AJZDiQApG/Q== X-Google-Smtp-Source: ACHHUZ68OPn5V/jfE6txOC1jcEuMfSLFraCN1sQJsIp1FRSytAN6L3p0tmjtRyonKxpVhrOJ1APFLA== X-Received: by 2002:a19:a410:0:b0:4db:456a:9a1 with SMTP id q16-20020a19a410000000b004db456a09a1mr2576511lfc.66.1682774036025; Sat, 29 Apr 2023 06:13:56 -0700 (PDT) Received: from surface-pro-6.. ([2a00:1370:818c:4a57:8a14:19ba:9e6b:1866]) by smtp.gmail.com with ESMTPSA id f27-20020ac251bb000000b004eb018fac57sm3744851lfk.191.2023.04.29.06.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Apr 2023 06:13:55 -0700 (PDT) From: Sergey Bugaev To: libc-alpha@sourceware.org Cc: bug-hurd@gnu.org, Samuel Thibault Subject: [PATCH 1/7] hurd: Simplify _hurd_critical_section_lock a bit Date: Sat, 29 Apr 2023 16:13:48 +0300 Message-Id: <20230429131354.2507443-1-bugaevc@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This block of code was doing exactly what _hurd_self_sigstate does; so just call that and let it do its job. Signed-off-by: Sergey Bugaev --- hurd/hurd/signal.h | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/hurd/hurd/signal.h b/hurd/hurd/signal.h index 662e955e..302ca25e 100644 --- a/hurd/hurd/signal.h +++ b/hurd/hurd/signal.h @@ -218,19 +218,7 @@ _hurd_critical_section_lock (void) return NULL; #endif - ss = THREAD_GETMEM (THREAD_SELF, _hurd_sigstate); - if (ss == NULL) - { - thread_t self = __mach_thread_self (); - - /* The thread variable is unset; this must be the first time we've - asked for it. In this case, the critical section flag cannot - possible already be set. Look up our sigstate structure the slow - way. */ - ss = _hurd_thread_sigstate (self); - THREAD_SETMEM (THREAD_SELF, _hurd_sigstate, ss); - __mach_port_deallocate (__mach_task_self (), self); - } + ss = _hurd_self_sigstate (); if (! __spin_try_lock (&ss->critical_section_lock)) /* We are already in a critical section, so do nothing. */ -- 2.40.1