From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id E15783858C50 for ; Sat, 29 Apr 2023 13:20:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E15783858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4ec816c9d03so1138442e87.2 for ; Sat, 29 Apr 2023 06:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682774455; x=1685366455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9PjP8XpnFODtLJpa74+j7ucmVulA2MHrcN3Pmri0rqo=; b=ANC/kuIBh8pLtsqWVj65UYvenhwQiU80s+H6P5hjnoLpaDfs4EizHpEefF1HjUW4rf Nk2kwjp/de3sX+wVIXKS5RH4n+HZSG/80qvOZcEXtnN47EC0kXxkrkIbhdEmXyutjzAl bW/xjNM5yTKh1UphTj/Sk1F7p/6LsmJg5So8Mus1gF7Rb6saehARO0dNrAOLH3AnXdgc imIjzO2DI81f8lcKgkRkfMI4YNLi0fXFafoFthdutEMR015wW2N5CfgVaNWJjiSNN5Tj 7SvDrIrwCLhuzGo0yjLmQs+bj/GbBllPbQ/GwqdlIOew8JeH3LXpDwG9urTiY1JG1Avu Hanw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682774455; x=1685366455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9PjP8XpnFODtLJpa74+j7ucmVulA2MHrcN3Pmri0rqo=; b=YvGLgReCJXP5Csp4ZPIUsM+RUxwGsrx3JStHujrepsubhP8hNzxO5bKFvxdda0YhnE xn9BcgOUKu6csqilgDYt0XT4DMQYS3cxKXYEH3cVZZnD9MT8SpbL7j9+hbqOcvEwpuRl MzIFzkBAFdhhEybUxYD+6Ir/pSrgWQJ4z8ilOJcjI6Yt7C39oBx9luwBPIUd4hNhQQ3q gS2cMFY5I7VXs6K83jVY16wvPMm0+Xm3SAPyijWXBqAbV+0IGlFbuCZ7d9RU/yLdSOkJ UnZh5G702stpRhFRp2tPlxpoQ01UQ2rqKNT9+Esc5meyaJxiPIETDvSy8MO9PE3kCqhO oh5A== X-Gm-Message-State: AC+VfDw+IZnCrqHOedAJJCIjvEndFzwcKoz+XSL5VGeE92qmgvN0xJlR SM7WyD/Rd/y2YU8DZ0WvzbPbISqnCRW2zw== X-Google-Smtp-Source: ACHHUZ72qhox2lil4TCsCi2eRVNOApOnjAfQu/j0wnE0jEk/fSry0auGV88cUUBPuwCqxeba9johAw== X-Received: by 2002:a19:7619:0:b0:4dd:cb1d:b3cc with SMTP id c25-20020a197619000000b004ddcb1db3ccmr2328494lff.11.1682774454959; Sat, 29 Apr 2023 06:20:54 -0700 (PDT) Received: from surface-pro-6.. ([2a00:1370:818c:4a57:8a14:19ba:9e6b:1866]) by smtp.gmail.com with ESMTPSA id g17-20020a05651c045100b0029c36ebf89asm3712371ljg.112.2023.04.29.06.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Apr 2023 06:20:54 -0700 (PDT) From: Sergey Bugaev To: libc-alpha@sourceware.org Cc: bug-hurd@gnu.org, Samuel Thibault Subject: Re: [PATCH] cdefs.h: Define __COLD Date: Sat, 29 Apr 2023 16:20:53 +0300 Message-Id: <20230429132053.2508965-1-bugaevc@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230429131223.2507236-1-bugaevc@gmail.com> References: <20230429131223.2507236-1-bugaevc@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: And of course right after I have sent it, I notice that I forgot the "Not GCC or clang." case. Sergey -- >8 -- >From 1b8c6563828399de563846525d0f525001f2d80d Mon Sep 17 00:00:00 2001 From: Sergey Bugaev Date: Thu, 27 Apr 2023 17:42:11 +0300 Subject: [PATCH] cdefs.h: Define __COLD This expands to __attribute__ ((cold)) when supported. It should be used to mark up functions that are invoked rarely. Signed-off-by: Sergey Bugaev --- misc/sys/cdefs.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h index 23ec0ebd..9a07e297 100644 --- a/misc/sys/cdefs.h +++ b/misc/sys/cdefs.h @@ -98,6 +98,12 @@ # endif # endif +# if __GNUC_PREREQ (4, 3) || __glibc_has_attribute (__cold__) +# define __COLD __attribute__ ((__cold__)) +# else +# define __COLD +# endif + #else /* Not GCC or clang. */ # if (defined __cplusplus \ @@ -110,6 +116,7 @@ # define __THROW # define __THROWNL # define __NTH(fct) fct +# define __COLD #endif /* GCC || clang. */ -- 2.40.1