From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C90523858431 for ; Sat, 29 Apr 2023 14:52:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C90523858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pslvp-0008Vm-Aq; Sat, 29 Apr 2023 10:52:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=v14n2mtWbmjK9zHqEsk1HOChYctEKJIqkiiR8VVku/k=; b=jISVQHKG6Jbq075SSx6B 6x0BXUIC/q0xnBV/3pOQsyfTEQ/WeRIBfpN1msvs4coVl04v1G1DOUU4ngEH22ot8SBRBuF+UEDxO Az/TI9gWlWUcYinX5jZQws6HSFOMZ7a0zUYMYPPFcpXkWPKAlqQ5C01HGpmVt88DC+fOEqbe2iUFR 8hszNi7xu2UgEwFc1jehx9rBUq+/eXKSGZxq9kXvfo0LRbQ7VVHNafiqNbV44iLBlY8u0eItX7gNI 9p2a5xfy0Mdzk1UJB/3hbtGj4sBQRv9wG09PGFliXSWobmav3ThuS53HEQy6QI9Aa9aWR3CY9oKiW W0cycyO9T8qqpA==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin.home) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pslvo-00082d-RA; Sat, 29 Apr 2023 10:52:12 -0400 Received: from samy by begin.home with local (Exim 4.96) (envelope-from ) id 1pslvn-002EKX-17; Sat, 29 Apr 2023 16:52:11 +0200 Date: Sat, 29 Apr 2023 16:52:11 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [PATCH 2/7] hurd: Move libc_hidden_def's around Message-ID: <20230429145211.73lu43smetwatdzm@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230429131354.2507443-1-bugaevc@gmail.com> <20230429131354.2507443-2-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230429131354.2507443-2-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied, thanks! Sergey Bugaev via Libc-alpha, le sam. 29 avril 2023 16:13:49 +0300, a ecrit: > Each libc_hidden_def should be placed immediately next to its function, > not in some random unrelated place. > > No functional change. > > Fixes: 653d74f12abea144219af00400ed1f1ac5dfa79f > "hurd: Global signal disposition" > > Signed-off-by: Sergey Bugaev > --- > hurd/hurdsig.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/hurd/hurdsig.c b/hurd/hurdsig.c > index c84de4db..78ea59d9 100644 > --- a/hurd/hurdsig.c > +++ b/hurd/hurdsig.c > @@ -174,6 +174,7 @@ _hurd_sigstate_set_global_rcv (struct hurd_sigstate *ss) > assert (ss->thread != MACH_PORT_NULL); > ss->actions[0].sa_handler = SIG_IGN; > } > +libc_hidden_def (_hurd_sigstate_set_global_rcv) > > /* Check whether SS is a global receiver. */ > static int > @@ -193,6 +194,8 @@ _hurd_sigstate_lock (struct hurd_sigstate *ss) > __spin_lock (&_hurd_global_sigstate->lock); > __spin_lock (&ss->lock); > } > +libc_hidden_def (_hurd_sigstate_lock) > + > void > _hurd_sigstate_unlock (struct hurd_sigstate *ss) > { > @@ -200,7 +203,7 @@ _hurd_sigstate_unlock (struct hurd_sigstate *ss) > if (sigstate_is_global_rcv (ss)) > __spin_unlock (&_hurd_global_sigstate->lock); > } > -libc_hidden_def (_hurd_sigstate_set_global_rcv) > +libc_hidden_def (_hurd_sigstate_unlock) > > /* Retrieve a thread's full set of pending signals, including the global > ones if appropriate. SS must be locked. */ > @@ -212,6 +215,7 @@ _hurd_sigstate_pending (const struct hurd_sigstate *ss) > __sigorset (&pending, &pending, &_hurd_global_sigstate->pending); > return pending; > } > +libc_hidden_def (_hurd_sigstate_pending) > > /* Clear a pending signal and return the associated detailed > signal information. SS must be locked, and must have signal SIGNO > @@ -230,8 +234,6 @@ sigstate_clear_pending (struct hurd_sigstate *ss, int signo) > __sigdelset (&ss->pending, signo); > return ss->pending_data[signo]; > } > -libc_hidden_def (_hurd_sigstate_lock) > -libc_hidden_def (_hurd_sigstate_unlock) > > /* Retrieve a thread's action vector. SS must be locked. */ > struct sigaction * > @@ -242,7 +244,6 @@ _hurd_sigstate_actions (struct hurd_sigstate *ss) > else > return ss->actions; > } > -libc_hidden_def (_hurd_sigstate_pending) > > > /* Signal delivery itself is on this page. */ > -- > 2.40.1 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.