From: Samuel Thibault <samuel.thibault@gnu.org>
To: "Cristian Rodríguez" <cristian@rodriguez.im>
Cc: Sergey Bugaev <bugaevc@gmail.com>,
libc-alpha@sourceware.org, bug-hurd@gnu.org
Subject: Re: [PATCH 3/3] Mark various cold functions as __COLD
Date: Mon, 1 May 2023 23:54:26 +0200 [thread overview]
Message-ID: <20230501215426.ihg3dpichaxtecvz@begin> (raw)
In-Reply-To: <CAPBLoAeBNykbmYhz7tYJFnQQU=xhBkXTJjkzxhBTacM8f4-jNw@mail.gmail.com>
Cristian Rodríguez, le lun. 01 mai 2023 17:52:17 -0400, a ecrit:
> On Sat, Apr 29, 2023 at 9:12 AM Sergey Bugaev via Libc-alpha <[1]
> libc-alpha@sourceware.org> wrote:
>
> GCC docs explicitly list perror () as a good candidate for using
> __attribute__ ((cold)). So apply __COLD to perror () and similar
> functions.
>
>
> abort() and all the function wrappers called by assert on failure are also
> cold.
Indeed, most __noreturn__ functions a probably worth having a look at.
Samuel
next prev parent reply other threads:[~2023-05-01 21:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-29 13:12 [PATCH 1/3] cdefs.h: Define __COLD Sergey Bugaev
2023-04-29 13:12 ` [PATCH 2/3] hurd: Mark error functions as __COLD Sergey Bugaev
2023-04-29 15:04 ` Samuel Thibault
2023-04-29 13:12 ` [PATCH 3/3] Mark various cold " Sergey Bugaev
2023-04-29 15:06 ` Samuel Thibault
2023-05-01 16:15 ` Siddhesh Poyarekar
2023-05-01 17:38 ` Samuel Thibault
2023-05-01 21:52 ` Cristian Rodríguez
2023-05-01 21:54 ` Samuel Thibault [this message]
2023-05-02 6:45 ` Sergey Bugaev
2023-04-29 13:20 ` [PATCH] cdefs.h: Define __COLD Sergey Bugaev
2023-04-29 15:02 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230501215426.ihg3dpichaxtecvz@begin \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=bugaevc@gmail.com \
--cc=cristian@rodriguez.im \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).