From: Samuel Thibault <samuel.thibault@gnu.org>
To: Flavio Cruz <flaviocruz@gmail.com>
Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org
Subject: Re: [PATCH glibc] Update hurd/hurdselect.c to be more portable.
Date: Sat, 6 May 2023 21:47:24 +0200 [thread overview]
Message-ID: <20230506194724.zlfumnpvhep6t2dy@begin> (raw)
In-Reply-To: <ZFSEF+GA2jNNZBwx@jupiter.tail36e24.ts.net>
Flavio Cruz, le ven. 05 mai 2023 00:20:39 -0400, a ecrit:
> + /* TODO: add this assertion for x86_64. */
> +#ifndef __x86_64__
> + _Static_assert (sizeof (uint32_t) == sizeof (mach_msg_type_t),
> + "mach_msg_type_t needs to be the same size as uint32_t");
> +#endif
Now that it is static, rather move it to
> +++ b/sysdeps/mach/mach_rpc.h
> +
> +/* Macro used by MIG to cleanly check the type. */
> +#define BAD_TYPECHECK(type, check) __glibc_unlikely (({ \
> + union { mach_msg_type_t t; uint32_t w; } _t, _c; \
> + _t.t = *(type); _c.t = *(check);_t.w != _c.w; }))
so it is tied to what it matters for?
next prev parent reply other threads:[~2023-05-06 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 4:20 Flavio Cruz
2023-05-06 19:47 ` Samuel Thibault [this message]
2023-05-06 20:55 Flavio Cruz
2023-05-06 21:11 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230506194724.zlfumnpvhep6t2dy@begin \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=flaviocruz@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).