public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Paul Pluzhnikov <ppluzhnikov@google.com>
To: libc-alpha@sourceware.org
Cc: Hsiangkai Wang <kai.wang@sifive.com>,
	Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: [PATCH] Fix elf/tst-glibelf [BZ# 30402]
Date: Sun,  7 May 2023 02:37:37 +0000	[thread overview]
Message-ID: <20230507023737.4052382-1-ppluzhnikov@google.com> (raw)

Commit 117e8b341c5 added duplicate definitions of DT_RISCV_VARIANT_CC and
STO_RISCV_VARIANT_CC, as well as defining DT_RISCV_NUM to 2
(conflicts with DT_PLTRELSZ wich is also 2).

This broke several tests: elf/tst-glibcelf, elf/tst-relro-ldso,
elf/tst-relro-libc.

Fix this by reverting changes to elf/elf.h and updating
sysdeps/riscv/dl-dtprocnum.h to define DT_THISPROCNUM directly.
---
 elf/elf.h                    | 7 -------
 sysdeps/riscv/dl-dtprocnum.h | 2 +-
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/elf/elf.h b/elf/elf.h
index 4f65b5a32d..94ca23c1bb 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -3933,13 +3933,6 @@ enum
 
 #define R_TILEGX_NUM		130
 
-/* RISC-V specific values for the Dyn d_tag field.  */
-#define DT_RISCV_VARIANT_CC	(DT_LOPROC + 1)
-#define DT_RISCV_NUM		2
-
-/* RISC-V specific values for the st_other field.  */
-#define STO_RISCV_VARIANT_CC 0x80
-
 /* RISC-V ELF Flags */
 #define EF_RISCV_RVC 			0x0001
 #define EF_RISCV_FLOAT_ABI 		0x0006
diff --git a/sysdeps/riscv/dl-dtprocnum.h b/sysdeps/riscv/dl-dtprocnum.h
index 281c5aadeb..d16f2415b5 100644
--- a/sysdeps/riscv/dl-dtprocnum.h
+++ b/sysdeps/riscv/dl-dtprocnum.h
@@ -18,4 +18,4 @@
 
 /* Number of extra dynamic section entries for this architecture.  By
    default there are none.  */
-#define DT_THISPROCNUM	DT_RISCV_NUM
+#define DT_THISPROCNUM 2
-- 
2.40.1.521.gf1e218fcd8-goog


             reply	other threads:[~2023-05-07  2:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07  2:37 Paul Pluzhnikov [this message]
2023-05-07  2:42 ` Paul Pluzhnikov
2023-05-07  2:59 ` Xi Ruoyao
2023-05-07  3:06   ` [PATCH] Fix [BZ# 30402] (failing tests elf/tst-{glibcelf,relro-ldso,relro-libc}) Paul Pluzhnikov
2023-05-07 12:35 ` [PATCH] Fix elf/tst-glibelf [BZ# 30402] Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230507023737.4052382-1-ppluzhnikov@google.com \
    --to=ppluzhnikov@google.com \
    --cc=kai.wang@sifive.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).