From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id B384D3857036 for ; Wed, 10 May 2023 23:28:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B384D3857036 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwtEm-0005B1-8Q; Wed, 10 May 2023 19:28:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=wt44GkMXButZh33IdL7Q18fkzxoOHV0KexvLF2UifBU=; b=eeawxFoED3UKwO1u+5f3 pyf8G0WUHHoujbfR5VaHKFFb8JYorCzLNzy7wl2BP+DI7B2AyOyKTNATwFVVHqrIOLquE1cVfOKN3 4M9bSRg4YPP0Tp0vV+FR/ofpORDMjhUhGVM5aTlleIlCqAReJA99fbgR8glNb3E103DH1bzdHMtDs Rf5eiQjE5pPBdNDRfv65xlfPKb/A+fJZh+oUN9Ov+o3mT9MVdwUGdQBTaXR6504PdtIXT7FwUjjT2 WiMhBafvx+Jaw77PxXFTosYcAQebmgukQW19og+peb4FLC+VALSVXZaho7FSklsysRGdRxn7giYzr rg1EyaPqdNOGEQ==; Received: from lfbn-bor-1-1163-184.w92-158.abo.wanadoo.fr ([92.158.138.184] helo=begin.home) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwtEm-0000No-0N; Wed, 10 May 2023 19:28:48 -0400 Received: from samy by begin.home with local (Exim 4.96) (envelope-from ) id 1pwtEk-0053V1-34; Thu, 11 May 2023 01:28:46 +0200 Date: Thu, 11 May 2023 01:28:46 +0200 From: Samuel Thibault To: Flavio Cruz Cc: bug-hurd@gnu.org, libc-alpha@sourceware.org Subject: Re: [PATCH glibc] Stop checking if MiG supports retcode. Message-ID: <20230510232846.qkzucr436sqppy54@begin> Mail-Followup-To: Flavio Cruz , bug-hurd@gnu.org, libc-alpha@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied, thanks! Flavio Cruz, le mer. 10 mai 2023 01:20:34 -0400, a ecrit: > We already did the same change for Hurd > (https://git.savannah.gnu.org/cgit/hurd/hurd.git/commit/?id=ef5924402864ef049f40a39e73967628583bc1a4) > > Due to MiG requiring the subsystem to be defined early in order to know the > size of a port, this was causing a division by zero error during ./configure. > We could have just move subsystem to the top of the snippet, however it is > simpler to just remove the check given that we have no plans to use some other > MiG anyway. > > HAVE_MIG_RETCODE is removed completely since this will be a no-op either > way (compiling against old Hurd headers will work the same, new Hurd > headers will result in the same stubs since retcode is a no-op). > --- > config.h.in | 3 --- > sysdeps/mach/configure | 36 ------------------------------------ > sysdeps/mach/configure.ac | 26 -------------------------- > 3 files changed, 65 deletions(-) > > diff --git a/config.h.in b/config.h.in > index c87008b6a9..44a34072a4 100644 > --- a/config.h.in > +++ b/config.h.in > @@ -150,9 +150,6 @@ > /* Override abi-tags ABI version if necessary. */ > #undef __ABI_TAG_VERSION > > -/* Mach/Hurd specific: define if mig supports the `retcode' keyword. */ > -#undef HAVE_MIG_RETCODE > - > /* Mach specific: define if the `host_page_size' RPC is available. */ > #undef HAVE_HOST_PAGE_SIZE > > diff --git a/sysdeps/mach/configure b/sysdeps/mach/configure > index b08872b8bc..df20d8640f 100644 > --- a/sysdeps/mach/configure > +++ b/sysdeps/mach/configure > @@ -485,40 +485,4 @@ if test $libc_cv_mach_i386_gdt = yes; then > fi > > > - > -# See if mig groks `retcode'. > -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $MIG supports the retcode keyword" >&5 > -$as_echo_n "checking whether $MIG supports the retcode keyword... " >&6; } > -if ${hurd_cv_mig_retcode+:} false; then : > - $as_echo_n "(cached) " >&6 > -else > - cat > conftest.defs <<\EOF > -#include > -#include > -subsystem foobar 1000; > -type reply_port_t = polymorphic | MACH_MSG_TYPE_PORT_SEND_ONCE > - ctype: mach_port_t; > -simpleroutine foobar_reply ( > - reply_port: reply_port_t; > - err: kern_return_t, RetCode); > -EOF > -if { ac_try='CC="${CC}" ${MIG-false} -n conftest.defs 1>&5' > - { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 > - (eval $ac_try) 2>&5 > - ac_status=$? > - $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 > - test $ac_status = 0; }; }; then > - hurd_cv_mig_retcode=yes > -else > - hurd_cv_mig_retcode=no > -fi > -rm -f conftest* > -fi > -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $hurd_cv_mig_retcode" >&5 > -$as_echo "$hurd_cv_mig_retcode" >&6; } > -if test $hurd_cv_mig_retcode = yes; then > - $as_echo "#define HAVE_MIG_RETCODE 1" >>confdefs.h > - > -fi > - > CPPFLAGS=$OLD_CPPFLAGS > diff --git a/sysdeps/mach/configure.ac b/sysdeps/mach/configure.ac > index 537677c1d7..869cc9f820 100644 > --- a/sysdeps/mach/configure.ac > +++ b/sysdeps/mach/configure.ac > @@ -104,30 +104,4 @@ if test $libc_cv_mach_i386_gdt = yes; then > AC_DEFINE([HAVE_I386_SET_GDT]) > fi > > -dnl Swiped from hurd/aclocal.m4 > -AC_DEFUN([hurd_MIG_RETCODE], [dnl > -# See if mig groks `retcode'. > -AC_CACHE_CHECK(whether $MIG supports the retcode keyword, hurd_cv_mig_retcode, > -[cat > conftest.defs <<\EOF > -#include > -#include > -subsystem foobar 1000; > -type reply_port_t = polymorphic | MACH_MSG_TYPE_PORT_SEND_ONCE > - ctype: mach_port_t; > -simpleroutine foobar_reply ( > - reply_port: reply_port_t; > - err: kern_return_t, RetCode); > -EOF > -if AC_TRY_COMMAND([CC="${CC}" ${MIG-false} -n conftest.defs 1>&AS_MESSAGE_LOG_FD]); then > - hurd_cv_mig_retcode=yes > -else > - hurd_cv_mig_retcode=no > -fi > -rm -f conftest*]) > -if test $hurd_cv_mig_retcode = yes; then > - AC_DEFINE(HAVE_MIG_RETCODE) > -fi]) > - > -hurd_MIG_RETCODE > - > CPPFLAGS=$OLD_CPPFLAGS > -- > 2.39.2 > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.