From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 258413858D1E for ; Wed, 17 May 2023 20:50:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 258413858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzO6K-0002IB-7b; Wed, 17 May 2023 16:50:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=khKVSnbyK7i9jTGgxJQ6CJbSKfM6kntdsWeajQD3zpM=; b=U1+WYAS+kcnPP0TKEUka SgabCT4uPv8PxbQ7yNTP7ve6hZ3haWNZBCRhU9dB7M3spV8QCR2FhXyZSjwFoAKsLmgXZId2+GyNA FoLKkNn6iIAcgwHm8NIj3yXTY7nhq0oIwPjGHF1PsHu3dl8HAtbDQYxTpBJIyoLzftBGc30lzENHh hAillQtAI7wfsJTSniIRR2HI7l28LUJZMPOWcapIOeU3WsGmp2e39xEI8arRiTkDvV+cJcKgn1dvP WmZQpYmE2HScgvQHGluwJ4yBOm2zE0oci4BxaGySdpZbeBYmxl4DAA2cI8oLN29v+O4ZwmtfRTcl4 eZtGxhdHjfCrCg==; Received: from 2a01cb008c251f00de41a9fffe47ec49.ipv6.abo.wanadoo.fr ([2a01:cb00:8c25:1f00:de41:a9ff:fe47:ec49] helo=begin.home) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzO6K-00082z-0q; Wed, 17 May 2023 16:50:24 -0400 Received: from samy by begin.home with local (Exim 4.96) (envelope-from ) id 1pzO6H-006KpU-1U; Wed, 17 May 2023 22:50:21 +0200 Date: Wed, 17 May 2023 22:50:21 +0200 From: Samuel Thibault To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd@gnu.org Subject: Re: [PATCH 01/10] Remove sysdeps/generic/thread_state.h Message-ID: <20230517205021.d36z3j6f2toqa5ac@begin> Mail-Followup-To: Sergey Bugaev , libc-alpha@sourceware.org, bug-hurd@gnu.org References: <20230517191436.73636-1-bugaevc@gmail.com> <20230517191436.73636-2-bugaevc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230517191436.73636-2-bugaevc@gmail.com> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sergey Bugaev, le mer. 17 mai 2023 22:14:27 +0300, a ecrit: > This is a Mach-specific thread state definitions, and it's already > handled by sysdeps/mach/thread_state.h. ? No, this is the template file for the per-arch files, that you'd fall down on when building for another arch, so you know what you're supposed to fill in. > Signed-off-by: Sergey Bugaev > --- > sysdeps/generic/thread_state.h | 51 ---------------------------------- > 1 file changed, 51 deletions(-) > delete mode 100644 sysdeps/generic/thread_state.h > > diff --git a/sysdeps/generic/thread_state.h b/sysdeps/generic/thread_state.h > deleted file mode 100644 > index 18926efb..00000000 > --- a/sysdeps/generic/thread_state.h > +++ /dev/null > @@ -1,51 +0,0 @@ > -/* Mach thread state definitions for machine-independent code. Stub version. > - Copyright (C) 1994-2023 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, see > - . */ > - > -/* Everything else is called `thread_state', but CMU's header file is > - called `thread_status'. Oh boy. */ > -#include > - > -/* Replace with "i386" or "mips" or whatever. */ > - > -/* This lets the kernel define architecture-specific registers for a new > - thread. */ > -#define MACHINE_NEW_THREAD_STATE_FLAVOR _NEW_THREAD_STATE > -/* This makes the kernel load all architectures-specific registers for the > - thread. */ > -#define MACHINE_THREAD_STATE_FLAVOR _THREAD_STATE > -#define MACHINE_THREAD_STATE_COUNT _THREAD_STATE_COUNT > - > -#define machine_thread_state _thread_state > - > -/* Define these to the member names in `struct _thread_state' > - for the PC and stack pointer. */ > -#define PC ? > -#define SP ? > - > -/* This structure should contain all of the different flavors of thread > - state structures which are meaningful for this machine. Every machine's > - definition of this structure should have a member `int set' which is a > - bit mask (1 << FLAVOR) of the flavors of thread state in the structure > - which are filled in; and a member `struct machine_thread_state basic'. > - On some machines those are the only members (e.g. i386); on others, > - there are several relevant flavors of thread state (e.g. mips). */ > -struct machine_thread_all_state > - { > - int set; /* Mask of bits (1 << FLAVOR). */ > - struct _thread_state basic; > - }; > -- > 2.40.1 > > -- Samuel --- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria.