From: Stas Sergeev <stsp2@yandex.ru>
To: libc-alpha@sourceware.org
Cc: Stas Sergeev <stsp2@yandex.ru>
Subject: [PATCH 07/14] split out _dl_finalize_segments()
Date: Thu, 18 May 2023 13:28:47 +0500 [thread overview]
Message-ID: <20230518082854.3903342-8-stsp2@yandex.ru> (raw)
In-Reply-To: <20230518082854.3903342-1-stsp2@yandex.ru>
This is needed so that further patches can move that to the
relocation code.
The test-suite was run on x86_64/64 and showed no regressions.
Signed-off-by: Stas Sergeev <stsp2@yandex.ru>
---
elf/dl-load.c | 3 +++
elf/dl-load.h | 5 +++++
elf/dl-map-segments.h | 36 +++++++++++++++++++++++++++++-------
3 files changed, 37 insertions(+), 7 deletions(-)
diff --git a/elf/dl-load.c b/elf/dl-load.c
index 4007a4aae3..28e582fbdf 100644
--- a/elf/dl-load.c
+++ b/elf/dl-load.c
@@ -1263,6 +1263,9 @@ _dl_map_object_from_fd (const char *name, const char *origname, int fd,
l->l_map_start = l->l_map_end = 0;
goto lose;
}
+ errstring = _dl_finalize_segments (l, type, loadcmds, nloadcmds);
+ if (__glibc_unlikely (errstring != NULL))
+ goto lose;
}
if (l->l_ld != 0)
diff --git a/elf/dl-load.h b/elf/dl-load.h
index 029181e8c8..61f5c4fadf 100644
--- a/elf/dl-load.h
+++ b/elf/dl-load.h
@@ -120,6 +120,11 @@ static const char *_dl_map_segments (struct link_map *l, int fd,
const size_t maplength,
struct link_map *loader);
+static const char *_dl_finalize_segments (struct link_map *l,
+ int type,
+ const struct loadcmd loadcmds[],
+ size_t nloadcmds);
+
/* All the error message strings _dl_map_segments might return are
listed here so that different implementations in different sysdeps
dl-map-segments.h files all use consistent strings that are
diff --git a/elf/dl-map-segments.h b/elf/dl-map-segments.h
index 080199b76e..da6b762bca 100644
--- a/elf/dl-map-segments.h
+++ b/elf/dl-map-segments.h
@@ -123,12 +123,10 @@ _dl_map_segments (struct link_map *l, int fd,
while (c < &loadcmds[nloadcmds])
{
- ElfW(Addr) hole_start, hole_size;
-
if (c->mapend > c->mapstart
/* Map the segment contents from the file. */
&& (__mmap ((void *) (l->l_addr + c->mapstart),
- c->mapend - c->mapstart, c->prot,
+ c->mapend - c->mapstart, PROT_READ | PROT_WRITE,
MAP_FIXED|MAP_COPY|MAP_FILE,
fd, c->mapoff)
== MAP_FAILED))
@@ -136,6 +134,34 @@ _dl_map_segments (struct link_map *l, int fd,
_dl_postprocess_loadcmd (l, header, c);
+ ++c;
+ }
+
+ /* Notify ELF_PREFERRED_ADDRESS that we have to load this one
+ fixed. */
+ ELF_FIXED_ADDRESS (loader, c->mapstart);
+
+ return NULL;
+}
+
+static __always_inline const char *
+_dl_finalize_segments (struct link_map *l, int type,
+ const struct loadcmd loadcmds[], size_t nloadcmds)
+{
+ const struct loadcmd *c = loadcmds;
+
+ while (c < &loadcmds[nloadcmds])
+ {
+ ElfW(Addr) hole_start, hole_size;
+
+ if (c->mapend > c->mapstart)
+ {
+ if (__mprotect ((void *) (l->l_addr + c->mapstart),
+ c->mapend - c->mapstart, c->prot) < 0)
+ return DL_MAP_SEGMENTS_ERROR_MPROTECT;
+
+ }
+
if (c->allocend > c->dataend)
{
/* Extra zero pages should appear at the end of this segment,
@@ -208,9 +234,5 @@ _dl_map_segments (struct link_map *l, int fd,
++c;
}
- /* Notify ELF_PREFERRED_ADDRESS that we have to load this one
- fixed. */
- ELF_FIXED_ADDRESS (loader, c->mapstart);
-
return NULL;
}
--
2.39.2
next prev parent reply other threads:[~2023-05-18 8:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 8:28 [PATCH 00/14] implement RTLD_NORELOCATE api [BZ #30007] Stas Sergeev
2023-05-18 8:28 ` [PATCH 01/14] elf: switch _dl_map_segment() to anonymous mapping Stas Sergeev
2023-05-18 8:28 ` [PATCH 02/14] use initial mmap also for ET_EXEC Stas Sergeev
2023-05-18 8:28 ` [PATCH 03/14] rework maphole Stas Sergeev
2023-05-18 8:28 ` [PATCH 04/14] split do_reloc_1() from dl_open_worker_begin() Stas Sergeev
2023-05-18 8:28 ` [PATCH 05/14] split do_reloc_2() out of do_open_worker() Stas Sergeev
2023-05-18 8:28 ` [PATCH 06/14] move relocation into _dl_object_reloc() func Stas Sergeev
2023-05-18 8:28 ` Stas Sergeev [this message]
2023-05-18 8:28 ` [PATCH 08/14] finalize elf segments on a relocation step Stas Sergeev
2023-05-18 8:28 ` [PATCH 09/14] implement RTLD_NORELOCATE dlopen() flag Stas Sergeev
2023-05-18 8:28 ` [PATCH 10/14] add test-case for RTLD_NORELOCATE Stas Sergeev
2023-05-18 8:28 ` [PATCH 11/14] implement dlrelocate() function Stas Sergeev
2023-05-18 8:28 ` [PATCH 12/14] implement RTLD_DI_MAPINFO dlinfo() request Stas Sergeev
2023-05-18 8:28 ` [PATCH 13/14] implement dlset_object_base() function Stas Sergeev
2023-05-18 8:28 ` [PATCH 14/14] implement RTLD_DI_DEPLIST dlinfo() request Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518082854.3903342-8-stsp2@yandex.ru \
--to=stsp2@yandex.ru \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).