From: Joe Simmons-Talbott <josimmon@redhat.com>
To: libc-alpha@sourceware.org
Cc: Joe Simmons-Talbott <josimmon@redhat.com>
Subject: [PATCH] resolv/res_query: Add not indicating that alloca usage is safe.
Date: Wed, 5 Jul 2023 14:07:03 -0400 [thread overview]
Message-ID: <20230705180703.1469847-1-josimmon@redhat.com> (raw)
The buffer size is small (< 1024) and fixed sized so alloca is safe
here.
---
resolv/res_query.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/resolv/res_query.c b/resolv/res_query.c
index 049de91b95..0e0e7be624 100644
--- a/resolv/res_query.c
+++ b/resolv/res_query.c
@@ -117,6 +117,7 @@ __res_context_query (struct resolv_context *ctx, const char *name,
int n, use_malloc = 0;
size_t bufsize = (type == T_QUERY_A_AND_AAAA ? 2 : 1) * QUERYSIZE;
+ /* alloca is safe here since bufsize < 1024 and fixed sized. */
u_char *buf = alloca (bufsize);
u_char *query1 = buf;
int nquery1 = -1;
--
2.39.2
next reply other threads:[~2023-07-05 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 18:07 Joe Simmons-Talbott [this message]
2023-07-05 18:13 ` Joe Simmons-Talbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705180703.1469847-1-josimmon@redhat.com \
--to=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).